From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDtlg-0002C6-7K for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:25:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDtla-00053L-9E for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:25:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDtla-00053H-3J for qemu-devel@nongnu.org; Fri, 17 Jun 2016 09:24:58 -0400 References: <1466167331-17063-1-git-send-email-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <8f698e6d-80db-71d5-93d1-7e4143858cb3@redhat.com> Date: Fri, 17 Jun 2016 15:24:53 +0200 MIME-Version: 1.0 In-Reply-To: <1466167331-17063-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] nbd/client.c: Correct trace format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Eric Blake On 17/06/2016 14:42, Peter Maydell wrote: > The trace format string in nbd_send_request uses PRIu16 for > request->type, but request->type is a uint32_t. This provokes > compiler warnings on the OSX clang. Use PRIu32 instead. > > Signed-off-by: Peter Maydell > --- > I didn't catch this when I ran the merge build test for the > pull request, because I don't have warnings-as-errors enabled > on the OSX test machine yet. Thanks, please apply directly if you wish. Paolo