From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A72C2D0E4 for ; Tue, 24 Nov 2020 07:56:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 092E6206B2 for ; Tue, 24 Nov 2020 07:56:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uy/A3i2i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 092E6206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khTBe-0003IC-GR for qemu-devel@archiver.kernel.org; Tue, 24 Nov 2020 02:56:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khTA2-0002kf-SL for qemu-devel@nongnu.org; Tue, 24 Nov 2020 02:54:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khTA0-000777-9E for qemu-devel@nongnu.org; Tue, 24 Nov 2020 02:54:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606204486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHQ+RPbLZWKYKtoGTLeAABZ4kWADp49n/lQrsr0ItNs=; b=Uy/A3i2iz7HcuZQc7d/dEwcHM4+sR3oGh5zbwFlZ+3jIqG7ZDLRmuKQKbCbDcbgHw5Z317 YHVl/b9yAioGMdW7/PIrHjFed5eNnj6QkGX29FhGu5G3oewGQE6UgFJ7TSbgFoyF7Nkxtr Q1KIaK66J/odm5yGzvpuV6VLgaul8UE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-7bLPPbuRObqsD3pQG--9nw-1; Tue, 24 Nov 2020 02:54:41 -0500 X-MC-Unique: 7bLPPbuRObqsD3pQG--9nw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 57B5D18C89CE; Tue, 24 Nov 2020 07:54:40 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-215.ams2.redhat.com [10.36.113.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 160DA60864; Tue, 24 Nov 2020 07:54:38 +0000 (UTC) Subject: Re: [PATCH v2 for-5.2] tests/9pfs: Mark "local" tests as "slow" To: Greg Kurz , Christian Schoenebeck References: <160620382310.1423262.7364287092069513483.stgit@bahia.lan> From: Thomas Huth Message-ID: <8f6b304b-1a7c-e16d-c413-170605599347@redhat.com> Date: Tue, 24 Nov 2020 08:54:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <160620382310.1423262.7364287092069513483.stgit@bahia.lan> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/11/2020 08.43, Greg Kurz wrote: > The "local" tests can fail on some automated build systems as > reported here: > > https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html > > This will need to be investigated and addressed later. Let's go for a > workaround in the meantime : mark the "local" tests as "slow" so that > they aren't executed with a simple "make check" like in the case above. > > Reported-by: Cole Robinson > Signed-off-by: Greg Kurz > --- > v2: - less noisy patch > --- > tests/qtest/virtio-9p-test.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c > index 21e340fa5f43..92a498f24925 100644 > --- a/tests/qtest/virtio-9p-test.c > +++ b/tests/qtest/virtio-9p-test.c > @@ -1456,6 +1456,15 @@ static void register_virtio_9p_test(void) > > > /* 9pfs test cases using the 'local' filesystem driver */ > + > + /* > + * XXX: Until we are sure that these tests can run everywhere, > + * keep them as "slow" so that they aren't run with "make check". > + */ > + if (!g_test_slow()) { > + return; > + } > + > opts.before = assign_9p_local_driver; > qos_add_test("local/config", "virtio-9p", pci_config, &opts); > qos_add_test("local/create_dir", "virtio-9p", fs_create_dir, &opts); Reviewed-by: Thomas Huth I assume you'll take this via the 9p tree? I don't have any other qtest patches pending right now, so I did not plan to send another pull request today...