qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
	qemu-ppc@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] target/ppc: fix signal delivery for ppc64abi32
Date: Wed, 11 Sep 2019 10:33:45 -0400	[thread overview]
Message-ID: <8f76ef47-0cf8-c662-0100-d416f5f2e0c1@linaro.org> (raw)
In-Reply-To: <20190911093951.6244-1-alex.bennee@linaro.org>

On 9/11/19 5:39 AM, Alex Bennée wrote:
> We were incorrectly setting NIP resulting in a segfault. This fixes
> linux-test for this ABI.

Perhaps better:
We were incorrectly using the 64-bit AIX ABI instead of the 32-bit SYSV ABI for
setting NIP for the signal handler.

?

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  linux-user/ppc/signal.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Anyway,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


  reply	other threads:[~2019-09-11 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  9:39 [Qemu-devel] [PATCH] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-11 14:33 ` Richard Henderson [this message]
2019-09-16  1:48   ` [Qemu-devel] [Qemu-ppc] " David Gibson
2019-09-16  7:22     ` Alex Bennée
2019-09-17  2:03       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f76ef47-0cf8-c662-0100-d416f5f2e0c1@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).