From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Remove "options" indirection from blockdev-add
Date: Fri, 7 Oct 2016 18:16:52 +0200 [thread overview]
Message-ID: <8f8ae9ea-3c17-82ed-7cca-2f7f63ceac46@redhat.com> (raw)
In-Reply-To: <1475854682-20667-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On 07.10.2016 17:38, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
>
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>
> Yes, that's right. Ignoring the test cases, this is a one-liner in
> the schema without any C code changes. :-)
While that is cool and correct, you also ignored the documentation
changes, which is probably not correct. :-)
(There are some blockdev-add examples in docs/qmp-commands.txt which
need to be adjusted.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 480 bytes --]
next prev parent reply other threads:[~2016-10-07 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:38 [Qemu-devel] [PATCH] block: Remove "options" indirection from blockdev-add Kevin Wolf
2016-10-07 16:16 ` Max Reitz [this message]
2016-10-07 17:18 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f8ae9ea-3c17-82ed-7cca-2f7f63ceac46@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).