From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsXpY-0007mU-Fx for qemu-devel@nongnu.org; Fri, 07 Oct 2016 12:17:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsXpX-0002pi-FM for qemu-devel@nongnu.org; Fri, 07 Oct 2016 12:17:04 -0400 References: <1475854682-20667-1-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <8f8ae9ea-3c17-82ed-7cca-2f7f63ceac46@redhat.com> Date: Fri, 7 Oct 2016 18:16:52 +0200 MIME-Version: 1.0 In-Reply-To: <1475854682-20667-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c9vUNA0VneGwuRkhiXaeJWWxAcm9ULQVq" Subject: Re: [Qemu-devel] [PATCH] block: Remove "options" indirection from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c9vUNA0VneGwuRkhiXaeJWWxAcm9ULQVq From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Message-ID: <8f8ae9ea-3c17-82ed-7cca-2f7f63ceac46@redhat.com> Subject: Re: [PATCH] block: Remove "options" indirection from blockdev-add References: <1475854682-20667-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1475854682-20667-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 07.10.2016 17:38, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level= > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains th= e > real arguments. >=20 > blockdev-add is still experimental and we already made substantial > changes to the API recently, so we're free to make changes like this > one, too. >=20 > Signed-off-by: Kevin Wolf > --- >=20 > Yes, that's right. Ignoring the test cases, this is a one-liner in > the schema without any C code changes. :-) While that is cool and correct, you also ignored the documentation changes, which is probably not correct. :-) (There are some blockdev-add examples in docs/qmp-commands.txt which need to be adjusted.) Max --c9vUNA0VneGwuRkhiXaeJWWxAcm9ULQVq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX98p0EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQBCk B/99vuTVikM7v/NgkOSWnozSEAkgsHs1Fl8lS8FubtJsQ2GtDh+UxKcM/B/hYYAR qjH+VMgXneNG/96CXAilvp+F7Q/uD/HnL7Qnh6HE4imzKAHgxr0u/ZgPjJZ73Iuh plma+FJePgh1qCjwMxH0zgRtBR3g7Fq2o0WPARvsZoZyGxiw5vodVvifIhRXJVT2 N0pXJxTdmr3LajfMTuvutXOaKURT59ZD3bZQi6rhd2yNJFqmWzqg2qNPVpRb+eQN oIhzbQ+hnBF0rWaL1HNz5W+OiCGOxpJ571JmeBBYJzBTmaXiIsnwJ5lc9uWQYqmm lUiT86FyQu9QmwQ7i56SmeLP =+DbZ -----END PGP SIGNATURE----- --c9vUNA0VneGwuRkhiXaeJWWxAcm9ULQVq--