Re: [RFC PATCH] tests/functional: Move tests into architecture specific folders

[Thomas Huth <thuth@redhat.com>]

On 10/07/2025 17.51, Pierrick Bouvier wrote:
> On 7/10/25 2:42 AM, Thomas Huth wrote:
>> This patch tackles two issues. First, the tests/functional folder has
>> become quite crowded already, some restructuring would be helpful here.
>> Second, we currently encode the target architecture twice in the test
>> names since a lot of the test file names contain the target, too.
>> This contributes to the very long output lines when running "make
>> check-functional".
>>
> 
> I agree with the "crowded" aspect of functional tests, and subfolders are 
> definitely welcome.
> 
> Concerning the long line, it seems that setup ("thorough" in this example) 
> is repeated 3 times on it, which is a bigger issue than having arch name 
> being repeated.
> 
> A simpler solution for the "long line" issue would be to change 
> mtest2make.py to generate shorter test target names. This would not benefit 
> for using meson test directly, but from what I understood, this is not 
> recommended nor supported anyway.

I agree that this is a bigger annoyance here, but as far as I understood 
that that repeated "thorough" term is just a listing of all the test suites 
that the test is part of. I think this would rather need to be fixed on the 
meson test runner side - why does meson list all test suites here? The one 
that applies to the current should be enough, shouldn't it?

  Thomas