From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [PATCH 6/8] vga: reindent memory access code
Date: Tue, 2 Jan 2024 11:00:53 +0100 [thread overview]
Message-ID: <8f99476e-ebff-4b33-a7f6-daea2b3b8eb8@linaro.org> (raw)
In-Reply-To: <20231231093918.239549-7-pbonzini@redhat.com>
On 31/12/23 10:39, Paolo Bonzini wrote:
> The next patch will reuse latched memory access in text modes. Start with
> a patch that moves the latched access code out of the "if".
>
> Best reviewed with "git diff -b".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/display/vga.c | 211 ++++++++++++++++++++++++-----------------------
> 1 file changed, 110 insertions(+), 101 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-01-02 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 9:39 [PATCH 0/8] vga: improve emulation fidelity Paolo Bonzini
2023-12-31 9:39 ` [PATCH 1/8] vga: remove unused macros Paolo Bonzini
2023-12-31 16:01 ` BALATON Zoltan
2024-01-02 15:13 ` Paolo Bonzini
2023-12-31 9:39 ` [PATCH 2/8] vga: introduce VGADisplayParams Paolo Bonzini
2024-01-02 9:59 ` Philippe Mathieu-Daudé
2023-12-31 9:39 ` [PATCH 3/8] vga: mask addresses in non-VESA modes to 256k Paolo Bonzini
2023-12-31 16:13 ` BALATON Zoltan
2023-12-31 9:39 ` [PATCH 4/8] vga: implement horizontal pel panning in graphics modes Paolo Bonzini
2023-12-31 9:39 ` [PATCH 5/8] vga: optimize horizontal pel panning in 256-color modes Paolo Bonzini
2023-12-31 16:27 ` BALATON Zoltan
2024-01-01 19:02 ` Paolo Bonzini
2024-01-02 11:45 ` BALATON Zoltan
2023-12-31 9:39 ` [PATCH 6/8] vga: reindent memory access code Paolo Bonzini
2024-01-02 10:00 ` Philippe Mathieu-Daudé [this message]
2023-12-31 9:39 ` [PATCH 7/8] vga: use latches in odd/even mode too Paolo Bonzini
2023-12-31 9:39 ` [PATCH 8/8] vga: sort-of implement word and double-word access modes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f99476e-ebff-4b33-a7f6-daea2b3b8eb8@linaro.org \
--to=philmd@linaro.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).