Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

[Paolo Bonzini <pbonzini@redhat.com>]

On 26/03/2018 14:14, Thomas Huth wrote:
>> +    object_ref(OBJECT(dev));
>> +    object_property_set_bool(OBJECT(dev), false, "realized", &err);
>> +    if (err) {
>> +        error_reportf_err(err, "Clean up of device %s failed: ",
>> +                          object_get_typename(OBJECT(dev)));
>> +        exit(1);
>> +    }
>> +    object_unref(OBJECT(dev));
>> +}
> 
> I'm not a qdev expert, but I wonder whether we need the full object_ref
> + unref dance here? If not, you could get rid of this function and
> simply do the object_property_set_bool(OBJECT(dev), false, "realized",
> &error_fatal) twice in i8257_dma_init() instead.

No, however we do need an object_unparent call.

Paolo