From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD8DFC6FD1D for ; Mon, 27 Mar 2023 18:05:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgrDF-0008KX-BI; Mon, 27 Mar 2023 14:04:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgrDB-0008Ga-MN for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:04:53 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgrD8-00062X-Tg for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:04:52 -0400 Received: by mail-pj1-x1034.google.com with SMTP id om3-20020a17090b3a8300b0023efab0e3bfso12592866pjb.3 for ; Mon, 27 Mar 2023 11:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679940289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DogCOJnc75WN/a/bLCyMEkOBJKwKB3Bk9qFPriLokwI=; b=PDXtAX8JTwW3xySTtCbid6DqpnVzH+PQwZ+2H3ibRUL8Okffykt2UPmOUfBSW9AkRN KRWAOdbcOcDcLySmwyI54mINT9WjDAigD8l1jvRhx9OorDqxA75zBx4GGCehOzJ5aiZ5 GquM5BhGW0Yb+n7f4gHuCLzNBIaU+4UwEpeweO6FutDpzxij+99Mjxmsj6FgO6leHbnT QUI5vj0ibrK1syEJvAOSm3zJkUUh+in3vbntl9GxJKnu2d6Gx8yJyiitwEF4DpklHuky f9qzMMIe5daSMS5vtopwb60JOv6/WIbUE3+nTcn+MDnqOjK0IISHtPurJk451lHR/2fC WtaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679940289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DogCOJnc75WN/a/bLCyMEkOBJKwKB3Bk9qFPriLokwI=; b=Xp7pSDd1qNanbme+TimACxfQ77zsT99y2NG67Wamj0OwBaB6vETRzgsUuegWcLlP5p gpl2lmHzTUHMa2lZuHI7pOoOGXqARJ1fQl2Lm6M2v7JTdkQB4Yc00klJNl091+LrIL9E wMcUOuElHQ3UC6nQaaBAKdd4z/RjdmsL46k83iZFBFVcxzZgrfBOEkNuzSQcD5lvl82x 5ipqIqLV5IHBhtip44kjoR/KJf1sy/2scYqawcINpTNKHpHNZ3chVVhltluqxLGzhNfn Ud1vJSAwVpovQ76k4DXPF6gL7J4Qx6UVL9dEy/EG1ytKsHzehamqZmC7GGQhh9mNLGaB GUQA== X-Gm-Message-State: AAQBX9dbWa4PeRvDLy6rtcxlSTzJuDTTsZjLtG7FizEhVYbHecmCfLhI SmLmQpTm4CaotaZw7QMH6+QLqw== X-Google-Smtp-Source: AKy350amYlvYvzxSJNrpaD/5TzG+kGfU76l7kUgJooE+j0czMg4aiODHjD7IVAovFziRRq/u6iZHFA== X-Received: by 2002:a17:90b:3eca:b0:237:5a3c:e86c with SMTP id rm10-20020a17090b3eca00b002375a3ce86cmr13925990pjb.24.1679940289218; Mon, 27 Mar 2023 11:04:49 -0700 (PDT) Received: from ?IPV6:2602:ae:1544:6601:6705:aa17:3641:e634? ([2602:ae:1544:6601:6705:aa17:3641:e634]) by smtp.gmail.com with ESMTPSA id y1-20020a17090a8b0100b002348d711ebbsm7809217pjn.16.2023.03.27.11.04.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 11:04:48 -0700 (PDT) Message-ID: <8fed2551-a67d-cd53-f5a1-f089f980aa08@linaro.org> Date: Mon, 27 Mar 2023 11:04:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 5/5] target/riscv: Add pointer mask support for instruction fetch Content-Language: en-US To: Weiwei Li , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230327100027.61160-1-liweiwei@iscas.ac.cn> <20230327100027.61160-6-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20230327100027.61160-6-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/27/23 03:00, Weiwei Li wrote: > @@ -1248,6 +1265,10 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > qemu_log_mask(CPU_LOG_MMU, "%s ad %" VADDR_PRIx " rw %d mmu_idx %d\n", > __func__, address, access_type, mmu_idx); > > + if (access_type == MMU_INST_FETCH) { > + address = adjust_pc_address(env, address); > + } Why do you want to do this so late, as opposed to earlier in cpu_get_tb_cpu_state? r~