From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Jan Kiszka" <jan.kiszka@siemens.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message
Date: Fri, 17 May 2019 16:28:59 +0800 [thread overview]
Message-ID: <8ff8f283-fa8f-acc1-9f31-414339a54d4d@redhat.com> (raw)
In-Reply-To: <20190515090805.44785-1-sgarzare@redhat.com>
On 2019/5/15 下午5:08, Stefano Garzarella wrote:
> Reword and add a missing parentheses at the end of the
> error message.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> v2:
> - Reworded the error message (Markus)
> - Added Marc-André's R-b
> I made a little change to the error message, let me now
> if I should remove yuor R-b.
> ---
> net/slirp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 95934fb36d..b34cb29276 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -498,7 +498,8 @@ static int net_slirp_init(NetClientState *peer, const char *model,
> }
> if (vprefix6_len < 0 || vprefix6_len > 126) {
> error_setg(errp,
> - "Invalid prefix provided (prefix len must be in range 0-126");
> + "Invalid IPv6 prefix provided "
> + "(IPv6 prefix length must be between 0 and 126)");
> return -1;
> }
>
Applied.
Thanks
prev parent reply other threads:[~2019-05-17 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 9:08 [Qemu-devel] [PATCH v2] net/slirp: fix the IPv6 prefix length error message Stefano Garzarella
2019-05-15 12:33 ` Markus Armbruster
2019-05-15 13:01 ` Stefano Garzarella
2019-05-15 16:17 ` Philippe Mathieu-Daudé
2019-05-17 8:28 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff8f283-fa8f-acc1-9f31-414339a54d4d@redhat.com \
--to=jasowang@redhat.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).