qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Joelle van Dyne <j@getutm.app>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 2/4] block: check for sys/disk.h
Date: Tue, 9 Mar 2021 13:09:02 +0100	[thread overview]
Message-ID: <9062f9f2-a287-d51b-84c1-ebf5193df803@redhat.com> (raw)
In-Reply-To: <20210309002741.85057-3-j@getutm.app>

On 3/9/21 1:27 AM, Joelle van Dyne wrote:
> Some BSD platforms do not have this header.
> 
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
>  meson.build | 1 +
>  block.c     | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 0e53876f69..ba0db9fa1f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1153,6 +1153,7 @@ config_host_data.set('HAVE_SYS_IOCCOM_H', cc.has_header('sys/ioccom.h'))
>  config_host_data.set('HAVE_SYS_KCOV_H', cc.has_header('sys/kcov.h'))
>  config_host_data.set('HAVE_SYSTEM_FUNCTION', cc.has_function('system', prefix: '#include <stdlib.h>'))
>  config_host_data.set('HAVE_HOST_BLOCK_DEVICE', have_host_block_device)
> +config_host_data.set('HAVE_SYS_DISK_H', cc.has_header('sys/disk.h'))

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  parent reply	other threads:[~2021-03-09 12:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  0:27 [PATCH v2 0/4] Disable unsupported features on iOS hosts Joelle van Dyne
2021-03-09  0:27 ` [PATCH v2 1/4] block: feature detection for host block support Joelle van Dyne
2021-03-09  0:27 ` [PATCH v2 2/4] block: check for sys/disk.h Joelle van Dyne
2021-03-09 11:25   ` Peter Maydell
2021-03-09 12:09   ` Philippe Mathieu-Daudé [this message]
2021-03-09  0:27 ` [PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Joelle van Dyne
2021-03-09 11:31   ` Peter Maydell
2021-03-09  0:27 ` [PATCH v2 4/4] slirp: feature detection for smbd Joelle van Dyne
2021-03-09 10:10   ` Peter Maydell
2021-03-09 12:12   ` Philippe Mathieu-Daudé
2021-03-09 14:09   ` Philippe Mathieu-Daudé
2021-03-09 18:11     ` Joelle van Dyne
2021-03-10  1:13       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9062f9f2-a287-d51b-84c1-ebf5193df803@redhat.com \
    --to=philmd@redhat.com \
    --cc=j@getutm.app \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).