From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, fam@euphon.net,
stefanha@redhat.com, den@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter
Date: Mon, 22 Apr 2019 08:39:58 -0500 [thread overview]
Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> (raw)
In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On 4/19/19 9:05 AM, Vladimir Sementsov-Ogievskiy wrote:
> This fixes at least one overflow in qcow2_process_discards, which
> passes 64bit region length to bdrv_pdiscard which bytes (or sectors in
s/which/where/
> the past) parameter is int since it's introduction in 0b919fae.
s/it's/its/
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block.h | 4 ++--
> block/io.c | 16 ++++++++--------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, den@virtuozzo.com,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter
Date: Mon, 22 Apr 2019 08:39:58 -0500 [thread overview]
Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> (raw)
Message-ID: <20190422133958.sijTJ4hQKJsRHA85PBNI6aW3wJxMcon49x_ogR3jm7Y@z> (raw)
In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On 4/19/19 9:05 AM, Vladimir Sementsov-Ogievskiy wrote:
> This fixes at least one overflow in qcow2_process_discards, which
> passes 64bit region length to bdrv_pdiscard which bytes (or sectors in
s/which/where/
> the past) parameter is int since it's introduction in 0b919fae.
s/it's/its/
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block.h | 4 ++--
> block/io.c | 16 ++++++++--------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-22 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 14:05 [Qemu-devel] [PATCH v3 0/3] Fix overflow bug in qcow2 discard Vladimir Sementsov-Ogievskiy
2019-04-19 14:05 ` Vladimir Sementsov-Ogievskiy
2019-04-19 14:05 ` [Qemu-devel] [PATCH v3 1/3] block/qcow2-refcount: add trace-point to qcow2_process_discards Vladimir Sementsov-Ogievskiy
2019-04-19 14:05 ` Vladimir Sementsov-Ogievskiy
2019-04-22 13:36 ` Eric Blake
2019-04-22 13:36 ` Eric Blake
2019-04-19 14:05 ` [Qemu-devel] [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter Vladimir Sementsov-Ogievskiy
2019-04-19 14:05 ` Vladimir Sementsov-Ogievskiy
2019-04-22 13:39 ` Eric Blake [this message]
2019-04-22 13:39 ` Eric Blake
2019-04-19 14:05 ` [Qemu-devel] [PATCH v3 3/3] iotests: test big qcow2 shrink Vladimir Sementsov-Ogievskiy
2019-04-19 14:05 ` Vladimir Sementsov-Ogievskiy
2019-04-22 13:59 ` Eric Blake
2019-04-22 13:59 ` Eric Blake
2019-04-22 15:03 ` Vladimir Sementsov-Ogievskiy
2019-04-22 15:03 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com \
--to=eblake@redhat.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).