From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIZFw-00062f-9O for qemu-devel@nongnu.org; Mon, 22 Apr 2019 09:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIZFv-0001Jo-C6 for qemu-devel@nongnu.org; Mon, 22 Apr 2019 09:45:12 -0400 References: <20190419140557.102725-1-vsementsov@virtuozzo.com> <20190419140557.102725-3-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> Date: Mon, 22 Apr 2019 08:39:58 -0500 MIME-Version: 1.0 In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw" Subject: Re: [Qemu-devel] [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, fam@euphon.net, stefanha@redhat.com, den@virtuozzo.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw From: Eric Blake To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, fam@euphon.net, stefanha@redhat.com, den@virtuozzo.com Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> Subject: Re: [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter References: <20190419140557.102725-1-vsementsov@virtuozzo.com> <20190419140557.102725-3-vsementsov@virtuozzo.com> In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/19/19 9:05 AM, Vladimir Sementsov-Ogievskiy wrote: > This fixes at least one overflow in qcow2_process_discards, which > passes 64bit region length to bdrv_pdiscard which bytes (or sectors in s/which/where/ > the past) parameter is int since it's introduction in 0b919fae. s/it's/its/ >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block.h | 4 ++-- > block/io.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAly9xC4ACgkQp6FrSiUn Q2rCKQf8CTj0kTk+LK6zavtyGvXLbOH0OlhaEe93ptRrcgD2TdLHsQpczwhpZ3Dw B5pejDggFQYHkgW11v67O/NH1YstYkRVsOBd9uphhjCkGUYayFvRHHC0egjGGEB+ 3NaXH1MIVGMMfu99VD7WeSR+gStsYj8MGCRNx98xyDFvsbdYanKrID6ahS8UuyuX otiszxOi/HUL23WFdSmPdegVWxv7nfmzdSlPuA0g+/JjXmMwjOv+jmWdR5LdfUf1 KmFjEGoH226p/NQsxCh0puI1JwquNJmTBYB5cbWA49lySLNsUQcFq5R9Xha0CBcc kr7x94RQ4wxdP98mW+E7DnMo02RxRA== =4lXO -----END PGP SIGNATURE----- --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C23C10F11 for ; Mon, 22 Apr 2019 13:46:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3818620685 for ; Mon, 22 Apr 2019 13:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3818620685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:37690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIZHA-0006ee-F0 for qemu-devel@archiver.kernel.org; Mon, 22 Apr 2019 09:46:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIZFw-00062f-9O for qemu-devel@nongnu.org; Mon, 22 Apr 2019 09:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIZFv-0001Jo-C6 for qemu-devel@nongnu.org; Mon, 22 Apr 2019 09:45:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40994) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIZB3-0006lk-6p; Mon, 22 Apr 2019 09:40:09 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 437A883F51; Mon, 22 Apr 2019 13:40:08 +0000 (UTC) Received: from [10.3.116.149] (ovpn-116-149.phx2.redhat.com [10.3.116.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D66F160C9A; Mon, 22 Apr 2019 13:39:59 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20190419140557.102725-1-vsementsov@virtuozzo.com> <20190419140557.102725-3-vsementsov@virtuozzo.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> Date: Mon, 22 Apr 2019 08:39:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 22 Apr 2019 13:40:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, den@virtuozzo.com, stefanha@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190422133958.sijTJ4hQKJsRHA85PBNI6aW3wJxMcon49x_ogR3jm7Y@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw From: Eric Blake To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, fam@euphon.net, stefanha@redhat.com, den@virtuozzo.com Message-ID: <9065c20c-d9bb-d84f-b5ca-16e929ca4d3a@redhat.com> Subject: Re: [PATCH v3 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter References: <20190419140557.102725-1-vsementsov@virtuozzo.com> <20190419140557.102725-3-vsementsov@virtuozzo.com> In-Reply-To: <20190419140557.102725-3-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/19/19 9:05 AM, Vladimir Sementsov-Ogievskiy wrote: > This fixes at least one overflow in qcow2_process_discards, which > passes 64bit region length to bdrv_pdiscard which bytes (or sectors in s/which/where/ > the past) parameter is int since it's introduction in 0b919fae. s/it's/its/ >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block.h | 4 ++-- > block/io.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAly9xC4ACgkQp6FrSiUn Q2rCKQf8CTj0kTk+LK6zavtyGvXLbOH0OlhaEe93ptRrcgD2TdLHsQpczwhpZ3Dw B5pejDggFQYHkgW11v67O/NH1YstYkRVsOBd9uphhjCkGUYayFvRHHC0egjGGEB+ 3NaXH1MIVGMMfu99VD7WeSR+gStsYj8MGCRNx98xyDFvsbdYanKrID6ahS8UuyuX otiszxOi/HUL23WFdSmPdegVWxv7nfmzdSlPuA0g+/JjXmMwjOv+jmWdR5LdfUf1 KmFjEGoH226p/NQsxCh0puI1JwquNJmTBYB5cbWA49lySLNsUQcFq5R9Xha0CBcc kr7x94RQ4wxdP98mW+E7DnMo02RxRA== =4lXO -----END PGP SIGNATURE----- --FPOw857kGdLrocd9cZ1H1E2jYmPRj4kuw--