Re: [PATCH 2/3] iotests: Disable unsubscriptable-object in pylint

[John Snow <jsnow@redhat.com>]

On 10/27/20 12:38 PM, Kevin Wolf wrote:
> When run with Python 3.9, pylint incorrectly warns about things like
> Optional[foo] because it doesn't recognise Optional as unsubscriptable.
> This is a known pylint bug:
> 
>      https://github.com/PyCQA/pylint/issues/3882
> 
> Just disable this check to get rid of the warnings.
> 
> Disabling this shouldn't make us miss any real bug because mypy also
> has a similar check ("... is not indexable").
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   tests/qemu-iotests/pylintrc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc
> index 5481afe528..cd3702e23c 100644
> --- a/tests/qemu-iotests/pylintrc
> +++ b/tests/qemu-iotests/pylintrc
> @@ -17,6 +17,8 @@ disable=invalid-name,
>           too-many-lines,
>           too-many-locals,
>           too-many-public-methods,
> +        # pylint warns about Optional[] etc. as unsubscriptable in 3.9
> +        unsubscriptable-object,
>           # These are temporary, and should be removed:
>           missing-docstring,
>   
> 

Reviewed-by: John Snow <jsnow@redhat.com>