From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
"Richard W.M. Jones" <rjones@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
amarnath.valluri@intel.com, marcandre.lureau@gmail.com
Subject: Re: [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM.
Date: Mon, 6 Nov 2017 12:52:35 -0500 [thread overview]
Message-ID: <90c15906-724b-fd8a-89eb-e012ea910623@linux.vnet.ibm.com> (raw)
In-Reply-To: <5888e39b-8f55-2d6b-afbe-da4727f23c2d@msgid.tls.msk.ru>
On 11/06/2017 12:49 PM, Michael Tokarev wrote:
> 19.10.2017 10:50, Richard W.M. Jones wrote:
>> When compiling with --disable-tpm:
>>
>> ../vl.o: In function `main':
>> /home/rjones/d/qemu/vl.c:4908: undefined reference to `tpm_cleanup'
>>
>> This appears to have been introduced in commit c37cacabf228
>> ("tpm: Move tpm_cleanup() to right place").
>>
>> index 0723835bbf..dbfd06d4bc 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4905,7 +4905,9 @@ int main(int argc, char **argv, char **envp)
>> res_free();
>>
>> /* vhost-user must be cleaned up before chardevs. */
>> +#ifdef CONFIG_TPM
>> tpm_cleanup();
>> +#endif
> Maybe we can define it to an empty macro (or inline function) in
> the header file instead?
It's solved with a stub in stubs/tpm.c.
Stefan
>
> /mjt
>
prev parent reply other threads:[~2017-11-06 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 7:50 [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM Richard W.M. Jones
2017-10-19 14:06 ` Stefan Berger
2017-10-23 21:03 ` Richard W.M. Jones
2017-11-06 17:49 ` Michael Tokarev
2017-11-06 17:52 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c15906-724b-fd8a-89eb-e012ea910623@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=amarnath.valluri@intel.com \
--cc=marcandre.lureau@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).