* various iotests failures apparently due to overly optimistic timeout settings
@ 2020-07-19 12:07 Peter Maydell
2020-07-20 10:46 ` Kevin Wolf
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2020-07-19 12:07 UTC (permalink / raw)
To: QEMU Developers; +Cc: Kevin Wolf, Qemu-block, Max Reitz
I just had a bunch of iotests fail on a freebsd VM test run.
I think the machine the VM runs on is sometimes a bit heavily
loaded for I/O, which means the VM can run slowly. This causes
various over-optimistic timeouts in the iotest testsuite to
spuriously fail. I also saw the 030 failure on the netbsd VM.
Can we try to avoid timing-sensitive tests where we can,
and make timeouts longer than 3 seconds where we can't, please?
This kind of intermittent failure makes my mergetests flaky.
Relevant bits of the log below, there are several different
flavours of failure.
TEST iotest-qcow2: 030 [fail]
QEMU --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
-nodefaults -display none -machine virt -accel qtest
QEMU_IMG --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
--cache writeback --aio threads -f qcow2
QEMU_NBD --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2 (compat=1.1)
IMGPROTO -- file
PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp.JFidXl5N
SOCKET_SCM_HELPER --
--- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/030.out
2020-07-19 09:29:05.000000000 +0000
+++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/030.out.bad
2020-07-19 09:52:04.256005000 +0000
@@ -1,5 +1,57 @@
-...........................
+WARNING:qemu.machine:qemu received signal 9; command:
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
-display none -vga none -chardev
socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
chardev=mon,mode=control -qtest
unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
-nodefaults -display none -machine virt -accel qtest -drive
if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads"
+WARNING:qemu.machine:qemu received signal 9; command:
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
-display none -vga none -chardev
socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
chardev=mon,mode=control -qtest
unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
-nodefaults -display none -machine virt -accel qtest -drive
if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base"
+...............E......E....
+======================================================================
+ERROR: test_set_speed (__main__.TestSetSpeed)
----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 436, in _do_shutdown
+ self._soft_shutdown(has_quit, timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 419, in _soft_shutdown
+ self._popen.wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
+ return self._wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
+ raise TimeoutExpired(self.args, timeout)
+subprocess.TimeoutExpired: Command
'['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
'-display', 'none', '-vga', 'none', '-chardev',
'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
'-mon', 'chardev=mon,mode=control', '-qtest',
'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
'-accel', 'qtest', '-drive',
'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads']'
timed out after 3 seconds
+
+The above exception was the direct cause of the following exception:
+
+Traceback (most recent call last):
+ File "030", line 900, in tearDown
+ self.vm.shutdown()
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 466, in shutdown
+ self._do_shutdown(has_quit, timeout=timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 440, in _do_shutdown
+ from exc
+qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
+
+======================================================================
+ERROR: test_stream_no_op (__main__.TestSingleDrive)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 436, in _do_shutdown
+ self._soft_shutdown(has_quit, timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 419, in _soft_shutdown
+ self._popen.wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
+ return self._wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
+ raise TimeoutExpired(self.args, timeout)
+subprocess.TimeoutExpired: Command
'['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
'-display', 'none', '-vga', 'none', '-chardev',
'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
'-mon', 'chardev=mon,mode=control', '-qtest',
'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
'-accel', 'qtest', '-drive',
'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base']'
timed out after 3 seconds
+
+The above exception was the direct cause of the following exception:
+
+Traceback (most recent call last):
+ File "030", line 131, in test_stream_no_op
+ self.vm.shutdown()
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 466, in shutdown
+ self._do_shutdown(has_quit, timeout=timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 440, in _do_shutdown
+ from exc
+qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
+
+----------------------------------------------------------------------
Ran 27 tests
-OK
+FAILED (errors=2)
TEST iotest-qcow2: 031
TEST iotest-qcow2: 032
TEST iotest-qcow2: 033
TEST iotest-qcow2: 034 [not run]
TEST iotest-qcow2: 035
TEST iotest-qcow2: 036
TEST iotest-qcow2: 037
TEST iotest-qcow2: 038 [not run]
TEST iotest-qcow2: 039 [not run]
TEST iotest-qcow2: 040 [fail]
QEMU --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
-nodefaults -display none -machine virt -accel qtest
QEMU_IMG --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
--cache writeback --aio threads -f qcow2
QEMU_NBD --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2 (compat=1.1)
IMGPROTO -- file
PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp.JFidXl5N
SOCKET_SCM_HELPER --
--- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/040.out
2020-07-19 09:29:05.000000000 +0000
+++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/040.out.bad
2020-07-19 09:55:10.837942000 +0000
@@ -1,5 +1,31 @@
-...........................................................
+WARNING:qemu.machine:qemu received signal 9; command:
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
-display none -vga none -chardev
socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock -mon
chardev=mon,mode=control -qtest
unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock -accel qtest
-nodefaults -display none -machine virt -accel qtest"
+...........................E...............................
+======================================================================
+ERROR: testIntermediateReadErrorStop (__main__.TestErrorHandling)
----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 436, in _do_shutdown
+ self._soft_shutdown(has_quit, timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 419, in _soft_shutdown
+ self._popen.wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
+ return self._wait(timeout=timeout)
+ File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
+ raise TimeoutExpired(self.args, timeout)
+subprocess.TimeoutExpired: Command
'['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
'-display', 'none', '-vga', 'none', '-chardev',
'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock',
'-mon', 'chardev=mon,mode=control', '-qtest',
'unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock', '-accel',
'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
'-accel', 'qtest']' timed out after 3 seconds
+
+The above exception was the direct cause of the following exception:
+
+Traceback (most recent call last):
+ File "040", line 687, in testIntermediateReadErrorStop
+ self.vm.shutdown()
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 466, in shutdown
+ self._do_shutdown(has_quit, timeout=timeout)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 440, in _do_shutdown
+ from exc
+qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
+
+----------------------------------------------------------------------
Ran 59 tests
-OK
+FAILED (errors=1)
TEST iotest-qcow2: 041 [fail]
QEMU --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
-nodefaults -disp
lay none -machine virt -accel qtest
QEMU_IMG --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
--cache writeback --aio threads -f qcow2
QEMU_NBD --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2 (compat=1.1)
IMGPROTO -- file
PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp.JFidXl5N
SOCKET_SCM_HELPER --
--- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/041.out
2020-07-19 09:29:05.000000000 +0000
+++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/041.out.bad
2020-07-19 10:05:09.812434000 +0000
@@ -1,5 +1,29 @@
-........................................................................................................
+...........................................................................E............................
+======================================================================
+ERROR: test_pause (__main__.TestSingleDrive)
----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "041", line 109, in test_pause
+ self.pause_job('drive0')
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
line 978, in pause_job
+ return self.pause_wait(job_id)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
line 964, in pause_wait
+ result = self.vm.qmp('query-block-jobs')
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
line 511, in qmp
+ return self._qmp.cmd(cmd, args=qmp_args)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
line 266, in cmd
+ return self.cmd_obj(qmp_cmd)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
line 247, in cmd_obj
+ resp = self.__json_read()
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
line 137, in __json_read
+ data = self.__sockfile.readline()
+ File "/usr/local/lib/python3.7/socket.py", line 589, in readinto
+ return self._sock.recv_into(b)
+ File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
line 416, in timeout
+ raise Exception(self.errmsg)
+Exception: Timeout waiting for job to pause
+
+----------------------------------------------------------------------
Ran 104 tests
-OK
+FAILED (errors=1)
[...]
TEST iotest-qcow2: 156 [fail]
QEMU --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
-nodefaults -disp
lay none -machine virt -accel qtest
QEMU_IMG --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
--cache writeback --aio threads -f qcow2
QEMU_NBD --
"/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2 (compat=1.1)
IMGPROTO -- file
PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp.JFidXl5N
SOCKET_SCM_HELPER --
--- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/156.out
2020-07-19 09:29:05.000000000 +0000
+++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/156.out.bad
2020-07-19 10:14:48.438647000 +0000
@@ -19,48 +19,4 @@
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id":
"source"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
"source"}}
{"return": {}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
"source"}}
-{"timestamp": {fcntl(): Bad file descriptor
"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event":
"BLOCK_JOB_READY", "data": {"device": "source", "len": 131072,
"offset": 131072, "speed": 0, "type": "mirror"}}
-{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
'qemu-io source "write -P 4 192k 64k"' } }
-wrote 65536/65536 bytes at offset 196608
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-{"return": ""}
-{ 'execute': 'block-job-complete', 'arguments': { 'device': 'source' } }
-{"return": {}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id":
"source"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id":
"source"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "BLOCK_JOB_COMPLETED", "data": {"device": "source", "len":
196608, "offset": 196608, "speed": 0, "type": "mirror"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id":
"source"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id":
"source"}}
-
-{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
'qemu-io source "read -P 1 0k 64k"' } }
-read 65536/65536 bytes at offset 0
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-{"return": ""}
-{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
'qemu-io source "read -P 2 64k 64k"' } }
-read 65536/65536 bytes at offset 65536
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-{"return": ""}
-{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
'qemu-io source "read -P 3 128k 64k"' } }
-read 65536/65536 bytes at offset 131072
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-{"return": ""}
-{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
'qemu-io source "read -P 4 192k 64k"' } }
-read 65536/65536 bytes at offset 196608
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-{"return": ""}
-
-{ 'execute': 'quit' }
-{"return": {}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "SHUTDOWN", "data": {"guest": false, "reason":
"host-qmp-quit"}}
-
-read 65536/65536 bytes at offset 0
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-read 65536/65536 bytes at offset 65536
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-read 65536/65536 bytes at offset 131072
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-read 65536/65536 bytes at offset 196608
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-
-*** done
+Timeout waiting for BLOCK_JOB_READY on handle 0
TEST iotest-qcow2: 158
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: various iotests failures apparently due to overly optimistic timeout settings
2020-07-19 12:07 various iotests failures apparently due to overly optimistic timeout settings Peter Maydell
@ 2020-07-20 10:46 ` Kevin Wolf
2020-07-20 14:12 ` John Snow
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2020-07-20 10:46 UTC (permalink / raw)
To: Peter Maydell; +Cc: jsnow, QEMU Developers, Qemu-block, Max Reitz
Am 19.07.2020 um 14:07 hat Peter Maydell geschrieben:
> I just had a bunch of iotests fail on a freebsd VM test run.
> I think the machine the VM runs on is sometimes a bit heavily
> loaded for I/O, which means the VM can run slowly. This causes
> various over-optimistic timeouts in the iotest testsuite to
> spuriously fail. I also saw the 030 failure on the netbsd VM.
>
> Can we try to avoid timing-sensitive tests where we can,
> and make timeouts longer than 3 seconds where we can't, please?
> This kind of intermittent failure makes my mergetests flaky.
John, I think this is a result of your recent python/qemu/ changes that
make failure of graceful shutdown an error rather than just silently
falling back to SIGKILL.
Should the default timeout be longer, should iotests override the
default, or should iotests just always kill their VM instead of trying
to shut it down gracefully?
Kevin
> Relevant bits of the log below, there are several different
> flavours of failure.
>
>
> TEST iotest-qcow2: 030 [fail]
> QEMU --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
> -nodefaults -display none -machine virt -accel qtest
> QEMU_IMG --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
> --cache writeback --aio threads -f qcow2
> QEMU_NBD --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2 (compat=1.1)
> IMGPROTO -- file
> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmp.JFidXl5N
> SOCKET_SCM_HELPER --
>
> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/030.out
> 2020-07-19 09:29:05.000000000 +0000
> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/030.out.bad
> 2020-07-19 09:52:04.256005000 +0000
> @@ -1,5 +1,57 @@
> -...........................
> +WARNING:qemu.machine:qemu received signal 9; command:
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
> -display none -vga none -chardev
> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
> chardev=mon,mode=control -qtest
> unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
> -nodefaults -display none -machine virt -accel qtest -drive
> if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads"
> +WARNING:qemu.machine:qemu received signal 9; command:
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
> -display none -vga none -chardev
> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
> chardev=mon,mode=control -qtest
> unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
> -nodefaults -display none -machine virt -accel qtest -drive
> if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base"
> +...............E......E....
> +======================================================================
> +ERROR: test_set_speed (__main__.TestSetSpeed)
> ----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 436, in _do_shutdown
> + self._soft_shutdown(has_quit, timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 419, in _soft_shutdown
> + self._popen.wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
> + return self._wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
> + raise TimeoutExpired(self.args, timeout)
> +subprocess.TimeoutExpired: Command
> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
> '-display', 'none', '-vga', 'none', '-chardev',
> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
> '-mon', 'chardev=mon,mode=control', '-qtest',
> 'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
> '-accel', 'qtest', '-drive',
> 'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads']'
> timed out after 3 seconds
> +
> +The above exception was the direct cause of the following exception:
> +
> +Traceback (most recent call last):
> + File "030", line 900, in tearDown
> + self.vm.shutdown()
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 466, in shutdown
> + self._do_shutdown(has_quit, timeout=timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 440, in _do_shutdown
> + from exc
> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
> +
> +======================================================================
> +ERROR: test_stream_no_op (__main__.TestSingleDrive)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 436, in _do_shutdown
> + self._soft_shutdown(has_quit, timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 419, in _soft_shutdown
> + self._popen.wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
> + return self._wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
> + raise TimeoutExpired(self.args, timeout)
> +subprocess.TimeoutExpired: Command
> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
> '-display', 'none', '-vga', 'none', '-chardev',
> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
> '-mon', 'chardev=mon,mode=control', '-qtest',
> 'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
> '-accel', 'qtest', '-drive',
> 'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base']'
> timed out after 3 seconds
> +
> +The above exception was the direct cause of the following exception:
> +
> +Traceback (most recent call last):
> + File "030", line 131, in test_stream_no_op
> + self.vm.shutdown()
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 466, in shutdown
> + self._do_shutdown(has_quit, timeout=timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 440, in _do_shutdown
> + from exc
> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
> +
> +----------------------------------------------------------------------
> Ran 27 tests
>
> -OK
> +FAILED (errors=2)
> TEST iotest-qcow2: 031
> TEST iotest-qcow2: 032
> TEST iotest-qcow2: 033
> TEST iotest-qcow2: 034 [not run]
> TEST iotest-qcow2: 035
> TEST iotest-qcow2: 036
> TEST iotest-qcow2: 037
> TEST iotest-qcow2: 038 [not run]
> TEST iotest-qcow2: 039 [not run]
> TEST iotest-qcow2: 040 [fail]
> QEMU --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
> -nodefaults -display none -machine virt -accel qtest
> QEMU_IMG --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
> --cache writeback --aio threads -f qcow2
> QEMU_NBD --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2 (compat=1.1)
> IMGPROTO -- file
> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmp.JFidXl5N
> SOCKET_SCM_HELPER --
>
> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/040.out
> 2020-07-19 09:29:05.000000000 +0000
> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/040.out.bad
> 2020-07-19 09:55:10.837942000 +0000
> @@ -1,5 +1,31 @@
> -...........................................................
> +WARNING:qemu.machine:qemu received signal 9; command:
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
> -display none -vga none -chardev
> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock -mon
> chardev=mon,mode=control -qtest
> unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock -accel qtest
> -nodefaults -display none -machine virt -accel qtest"
> +...........................E...............................
> +======================================================================
> +ERROR: testIntermediateReadErrorStop (__main__.TestErrorHandling)
> ----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 436, in _do_shutdown
> + self._soft_shutdown(has_quit, timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 419, in _soft_shutdown
> + self._popen.wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
> + return self._wait(timeout=timeout)
> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
> + raise TimeoutExpired(self.args, timeout)
> +subprocess.TimeoutExpired: Command
> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
> '-display', 'none', '-vga', 'none', '-chardev',
> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock',
> '-mon', 'chardev=mon,mode=control', '-qtest',
> 'unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock', '-accel',
> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
> '-accel', 'qtest']' timed out after 3 seconds
> +
> +The above exception was the direct cause of the following exception:
> +
> +Traceback (most recent call last):
> + File "040", line 687, in testIntermediateReadErrorStop
> + self.vm.shutdown()
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 466, in shutdown
> + self._do_shutdown(has_quit, timeout=timeout)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 440, in _do_shutdown
> + from exc
> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
> +
> +----------------------------------------------------------------------
> Ran 59 tests
>
> -OK
> +FAILED (errors=1)
> TEST iotest-qcow2: 041 [fail]
> QEMU --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
> -nodefaults -disp
> lay none -machine virt -accel qtest
> QEMU_IMG --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
> --cache writeback --aio threads -f qcow2
> QEMU_NBD --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2 (compat=1.1)
> IMGPROTO -- file
> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmp.JFidXl5N
> SOCKET_SCM_HELPER --
>
> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/041.out
> 2020-07-19 09:29:05.000000000 +0000
> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/041.out.bad
> 2020-07-19 10:05:09.812434000 +0000
> @@ -1,5 +1,29 @@
> -........................................................................................................
> +...........................................................................E............................
> +======================================================================
> +ERROR: test_pause (__main__.TestSingleDrive)
> ----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "041", line 109, in test_pause
> + self.pause_job('drive0')
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
> line 978, in pause_job
> + return self.pause_wait(job_id)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
> line 964, in pause_wait
> + result = self.vm.qmp('query-block-jobs')
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
> line 511, in qmp
> + return self._qmp.cmd(cmd, args=qmp_args)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 266, in cmd
> + return self.cmd_obj(qmp_cmd)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 247, in cmd_obj
> + resp = self.__json_read()
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
> line 137, in __json_read
> + data = self.__sockfile.readline()
> + File "/usr/local/lib/python3.7/socket.py", line 589, in readinto
> + return self._sock.recv_into(b)
> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
> line 416, in timeout
> + raise Exception(self.errmsg)
> +Exception: Timeout waiting for job to pause
> +
> +----------------------------------------------------------------------
> Ran 104 tests
>
> -OK
> +FAILED (errors=1)
>
> [...]
> TEST iotest-qcow2: 156 [fail]
> QEMU --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
> -nodefaults -disp
> lay none -machine virt -accel qtest
> QEMU_IMG --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
> --cache writeback --aio threads -f qcow2
> QEMU_NBD --
> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2 (compat=1.1)
> IMGPROTO -- file
> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmp.JFidXl5N
> SOCKET_SCM_HELPER --
>
> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/156.out
> 2020-07-19 09:29:05.000000000 +0000
> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/156.out.bad
> 2020-07-19 10:14:48.438647000 +0000
> @@ -19,48 +19,4 @@
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id":
> "source"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
> "source"}}
> {"return": {}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
> "source"}}
> -{"timestamp": {fcntl(): Bad file descriptor
> "seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event":
> "BLOCK_JOB_READY", "data": {"device": "source", "len": 131072,
> "offset": 131072, "speed": 0, "type": "mirror"}}
> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
> 'qemu-io source "write -P 4 192k 64k"' } }
> -wrote 65536/65536 bytes at offset 196608
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -{"return": ""}
> -{ 'execute': 'block-job-complete', 'arguments': { 'device': 'source' } }
> -{"return": {}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id":
> "source"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id":
> "source"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "BLOCK_JOB_COMPLETED", "data": {"device": "source", "len":
> 196608, "offset": 196608, "speed": 0, "type": "mirror"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id":
> "source"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id":
> "source"}}
> -
> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
> 'qemu-io source "read -P 1 0k 64k"' } }
> -read 65536/65536 bytes at offset 0
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -{"return": ""}
> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
> 'qemu-io source "read -P 2 64k 64k"' } }
> -read 65536/65536 bytes at offset 65536
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -{"return": ""}
> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
> 'qemu-io source "read -P 3 128k 64k"' } }
> -read 65536/65536 bytes at offset 131072
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -{"return": ""}
> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
> 'qemu-io source "read -P 4 192k 64k"' } }
> -read 65536/65536 bytes at offset 196608
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -{"return": ""}
> -
> -{ 'execute': 'quit' }
> -{"return": {}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "SHUTDOWN", "data": {"guest": false, "reason":
> "host-qmp-quit"}}
> -
> -read 65536/65536 bytes at offset 0
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -read 65536/65536 bytes at offset 65536
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -read 65536/65536 bytes at offset 131072
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -read 65536/65536 bytes at offset 196608
> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -
> -*** done
> +Timeout waiting for BLOCK_JOB_READY on handle 0
> TEST iotest-qcow2: 158
>
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: various iotests failures apparently due to overly optimistic timeout settings
2020-07-20 10:46 ` Kevin Wolf
@ 2020-07-20 14:12 ` John Snow
2020-07-20 14:15 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: John Snow @ 2020-07-20 14:12 UTC (permalink / raw)
To: Kevin Wolf, Peter Maydell; +Cc: QEMU Developers, Qemu-block, Max Reitz
On 7/20/20 6:46 AM, Kevin Wolf wrote:
> Am 19.07.2020 um 14:07 hat Peter Maydell geschrieben:
>> I just had a bunch of iotests fail on a freebsd VM test run.
>> I think the machine the VM runs on is sometimes a bit heavily
>> loaded for I/O, which means the VM can run slowly. This causes
>> various over-optimistic timeouts in the iotest testsuite to
>> spuriously fail. I also saw the 030 failure on the netbsd VM.
>>
>> Can we try to avoid timing-sensitive tests where we can,
>> and make timeouts longer than 3 seconds where we can't, please?
>> This kind of intermittent failure makes my mergetests flaky.
>
> John, I think this is a result of your recent python/qemu/ changes that
> make failure of graceful shutdown an error rather than just silently
> falling back to SIGKILL.
>
> Should the default timeout be longer, should iotests override the
> default, or should iotests just always kill their VM instead of trying
> to shut it down gracefully?
>
> Kevin
>
Let's make it longer. Since you are seeing the failures, can you edit
python/qemu/machine.py and find the default timeout of 3 seconds for
shutdown() and change it to 10? 30? 60?
3 seconds was enough for me, but they shouldn't be freezing.
If there are cases where the QEMU binary is hanging or not exiting
correctly, or it's not important that it exits correctly, we can
override it; in those cases use vm.kill() instead of vm.shutdown().
Or, if you want to try to shut it down normally but don't care if it
doesn't work right, you can do:
try:
vm.shutdown()
except AbornalShutdown:
pass
>> Relevant bits of the log below, there are several different
>> flavours of failure.
>>
>>
>> TEST iotest-qcow2: 030 [fail]
>> QEMU --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
>> -nodefaults -display none -machine virt -accel qtest
>> QEMU_IMG --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
>> QEMU_IO --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
>> --cache writeback --aio threads -f qcow2
>> QEMU_NBD --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
>> IMGFMT -- qcow2 (compat=1.1)
>> IMGPROTO -- file
>> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
>> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
>> SOCK_DIR -- /tmp/tmp.JFidXl5N
>> SOCKET_SCM_HELPER --
>>
>> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/030.out
>> 2020-07-19 09:29:05.000000000 +0000
>> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/030.out.bad
>> 2020-07-19 09:52:04.256005000 +0000
>> @@ -1,5 +1,57 @@
>> -...........................
>> +WARNING:qemu.machine:qemu received signal 9; command:
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
>> -display none -vga none -chardev
>> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
>> chardev=mon,mode=control -qtest
>> unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
>> -nodefaults -display none -machine virt -accel qtest -drive
>> if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads"
>> +WARNING:qemu.machine:qemu received signal 9; command:
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
>> -display none -vga none -chardev
>> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock -mon
>> chardev=mon,mode=control -qtest
>> unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock -accel qtest
>> -nodefaults -display none -machine virt -accel qtest -drive
>> if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base"
>> +...............E......E....
>> +======================================================================
>> +ERROR: test_set_speed (__main__.TestSetSpeed)
>> ----------------------------------------------------------------------
>> +Traceback (most recent call last):
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 436, in _do_shutdown
>> + self._soft_shutdown(has_quit, timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 419, in _soft_shutdown
>> + self._popen.wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
>> + return self._wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
>> + raise TimeoutExpired(self.args, timeout)
>> +subprocess.TimeoutExpired: Command
>> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
>> '-display', 'none', '-vga', 'none', '-chardev',
>> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
>> '-mon', 'chardev=mon,mode=control', '-qtest',
>> 'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
>> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
>> '-accel', 'qtest', '-drive',
>> 'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads']'
>> timed out after 3 seconds
>> +
>> +The above exception was the direct cause of the following exception:
>> +
>> +Traceback (most recent call last):
>> + File "030", line 900, in tearDown
>> + self.vm.shutdown()
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 466, in shutdown
>> + self._do_shutdown(has_quit, timeout=timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 440, in _do_shutdown
>> + from exc
>> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
>> +
>> +======================================================================
>> +ERROR: test_stream_no_op (__main__.TestSingleDrive)
>> +----------------------------------------------------------------------
>> +Traceback (most recent call last):
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 436, in _do_shutdown
>> + self._soft_shutdown(has_quit, timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 419, in _soft_shutdown
>> + self._popen.wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
>> + return self._wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
>> + raise TimeoutExpired(self.args, timeout)
>> +subprocess.TimeoutExpired: Command
>> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
>> '-display', 'none', '-vga', 'none', '-chardev',
>> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-24906-monitor.sock',
>> '-mon', 'chardev=mon,mode=control', '-qtest',
>> 'unix:path=/tmp/tmp.JFidXl5N/qemu-24906-qtest.sock', '-accel',
>> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
>> '-accel', 'qtest', '-drive',
>> 'if=virtio,id=drive0,file=blkdebug::/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch/test.img,format=qcow2,cache=writeback,aio=threads,backing.node-name=mid,backing.backing.node-name=base']'
>> timed out after 3 seconds
>> +
>> +The above exception was the direct cause of the following exception:
>> +
>> +Traceback (most recent call last):
>> + File "030", line 131, in test_stream_no_op
>> + self.vm.shutdown()
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 466, in shutdown
>> + self._do_shutdown(has_quit, timeout=timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 440, in _do_shutdown
>> + from exc
>> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
>> +
>> +----------------------------------------------------------------------
>> Ran 27 tests
>>
>> -OK
>> +FAILED (errors=2)
>> TEST iotest-qcow2: 031
>> TEST iotest-qcow2: 032
>> TEST iotest-qcow2: 033
>> TEST iotest-qcow2: 034 [not run]
>> TEST iotest-qcow2: 035
>> TEST iotest-qcow2: 036
>> TEST iotest-qcow2: 037
>> TEST iotest-qcow2: 038 [not run]
>> TEST iotest-qcow2: 039 [not run]
>> TEST iotest-qcow2: 040 [fail]
>> QEMU --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
>> -nodefaults -display none -machine virt -accel qtest
>> QEMU_IMG --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
>> QEMU_IO --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
>> --cache writeback --aio threads -f qcow2
>> QEMU_NBD --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
>> IMGFMT -- qcow2 (compat=1.1)
>> IMGPROTO -- file
>> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
>> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
>> SOCK_DIR -- /tmp/tmp.JFidXl5N
>> SOCKET_SCM_HELPER --
>>
>> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/040.out
>> 2020-07-19 09:29:05.000000000 +0000
>> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/040.out.bad
>> 2020-07-19 09:55:10.837942000 +0000
>> @@ -1,5 +1,31 @@
>> -...........................................................
>> +WARNING:qemu.machine:qemu received signal 9; command:
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64
>> -display none -vga none -chardev
>> socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock -mon
>> chardev=mon,mode=control -qtest
>> unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock -accel qtest
>> -nodefaults -display none -machine virt -accel qtest"
>> +...........................E...............................
>> +======================================================================
>> +ERROR: testIntermediateReadErrorStop (__main__.TestErrorHandling)
>> ----------------------------------------------------------------------
>> +Traceback (most recent call last):
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 436, in _do_shutdown
>> + self._soft_shutdown(has_quit, timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 419, in _soft_shutdown
>> + self._popen.wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
>> + return self._wait(timeout=timeout)
>> + File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
>> + raise TimeoutExpired(self.args, timeout)
>> +subprocess.TimeoutExpired: Command
>> '['/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64',
>> '-display', 'none', '-vga', 'none', '-chardev',
>> 'socket,id=mon,path=/tmp/tmp.JFidXl5N/qemu-27241-monitor.sock',
>> '-mon', 'chardev=mon,mode=control', '-qtest',
>> 'unix:path=/tmp/tmp.JFidXl5N/qemu-27241-qtest.sock', '-accel',
>> 'qtest', '-nodefaults', '-display', 'none', '-machine', 'virt',
>> '-accel', 'qtest']' timed out after 3 seconds
>> +
>> +The above exception was the direct cause of the following exception:
>> +
>> +Traceback (most recent call last):
>> + File "040", line 687, in testIntermediateReadErrorStop
>> + self.vm.shutdown()
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 466, in shutdown
>> + self._do_shutdown(has_quit, timeout=timeout)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 440, in _do_shutdown
>> + from exc
>> +qemu.machine.AbnormalShutdown: Could not perform graceful shutdown
>> +
>> +----------------------------------------------------------------------
>> Ran 59 tests
>>
>> -OK
>> +FAILED (errors=1)
>> TEST iotest-qcow2: 041 [fail]
>> QEMU --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
>> -nodefaults -disp
>> lay none -machine virt -accel qtest
>> QEMU_IMG --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
>> QEMU_IO --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
>> --cache writeback --aio threads -f qcow2
>> QEMU_NBD --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
>> IMGFMT -- qcow2 (compat=1.1)
>> IMGPROTO -- file
>> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
>> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
>> SOCK_DIR -- /tmp/tmp.JFidXl5N
>> SOCKET_SCM_HELPER --
>>
>> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/041.out
>> 2020-07-19 09:29:05.000000000 +0000
>> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/041.out.bad
>> 2020-07-19 10:05:09.812434000 +0000
>> @@ -1,5 +1,29 @@
>> -........................................................................................................
>> +...........................................................................E............................
>> +======================================================================
>> +ERROR: test_pause (__main__.TestSingleDrive)
>> ----------------------------------------------------------------------
>> +Traceback (most recent call last):
>> + File "041", line 109, in test_pause
>> + self.pause_job('drive0')
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
>> line 978, in pause_job
>> + return self.pause_wait(job_id)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
>> line 964, in pause_wait
>> + result = self.vm.qmp('query-block-jobs')
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/machine.py",
>> line 511, in qmp
>> + return self._qmp.cmd(cmd, args=qmp_args)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
>> line 266, in cmd
>> + return self.cmd_obj(qmp_cmd)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
>> line 247, in cmd_obj
>> + resp = self.__json_read()
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/../../python/qemu/qmp.py",
>> line 137, in __json_read
>> + data = self.__sockfile.readline()
>> + File "/usr/local/lib/python3.7/socket.py", line 589, in readinto
>> + return self._sock.recv_into(b)
>> + File "/usr/home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/iotests.py",
>> line 416, in timeout
>> + raise Exception(self.errmsg)
>> +Exception: Timeout waiting for job to pause
>> +
>> +----------------------------------------------------------------------
>> Ran 104 tests
>>
>> -OK
>> +FAILED (errors=1)
>>
>> [...]
>> TEST iotest-qcow2: 156 [fail]
>> QEMU --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64"
>> -nodefaults -disp
>> lay none -machine virt -accel qtest
>> QEMU_IMG --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-img"
>> QEMU_IO --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-io"
>> --cache writeback --aio threads -f qcow2
>> QEMU_NBD --
>> "/home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/../../qemu-nbd"
>> IMGFMT -- qcow2 (compat=1.1)
>> IMGPROTO -- file
>> PLATFORM -- FreeBSD/amd64 freebsd 12.1-RELEASE
>> TEST_DIR -- /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/scratch
>> SOCK_DIR -- /tmp/tmp.JFidXl5N
>> SOCKET_SCM_HELPER --
>>
>> --- /home/qemu/qemu-test.oJwuyW/src/tests/qemu-iotests/156.out
>> 2020-07-19 09:29:05.000000000 +0000
>> +++ /home/qemu/qemu-test.oJwuyW/build/tests/qemu-iotests/156.out.bad
>> 2020-07-19 10:14:48.438647000 +0000
>> @@ -19,48 +19,4 @@
>> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id":
>> "source"}}
>> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
>> "source"}}
>> {"return": {}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
>> "source"}}
>> -{"timestamp": {fcntl(): Bad file descriptor
>> "seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event":
>> "BLOCK_JOB_READY", "data": {"device": "source", "len": 131072,
>> "offset": 131072, "speed": 0, "type": "mirror"}}
>> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
>> 'qemu-io source "write -P 4 192k 64k"' } }
>> -wrote 65536/65536 bytes at offset 196608
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -{"return": ""}
>> -{ 'execute': 'block-job-complete', 'arguments': { 'device': 'source' } }
>> -{"return": {}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id":
>> "source"}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id":
>> "source"}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "BLOCK_JOB_COMPLETED", "data": {"device": "source", "len":
>> 196608, "offset": 196608, "speed": 0, "type": "mirror"}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id":
>> "source"}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id":
>> "source"}}
>> -
>> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
>> 'qemu-io source "read -P 1 0k 64k"' } }
>> -read 65536/65536 bytes at offset 0
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -{"return": ""}
>> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
>> 'qemu-io source "read -P 2 64k 64k"' } }
>> -read 65536/65536 bytes at offset 65536
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -{"return": ""}
>> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
>> 'qemu-io source "read -P 3 128k 64k"' } }
>> -read 65536/65536 bytes at offset 131072
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -{"return": ""}
>> -{ 'execute': 'human-monitor-command', 'arguments': { 'command-line':
>> 'qemu-io source "read -P 4 192k 64k"' } }
>> -read 65536/65536 bytes at offset 196608
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -{"return": ""}
>> -
>> -{ 'execute': 'quit' }
>> -{"return": {}}
>> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "SHUTDOWN", "data": {"guest": false, "reason":
>> "host-qmp-quit"}}
>> -
>> -read 65536/65536 bytes at offset 0
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -read 65536/65536 bytes at offset 65536
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -read 65536/65536 bytes at offset 131072
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -read 65536/65536 bytes at offset 196608
>> -64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> -
>> -*** done
>> +Timeout waiting for BLOCK_JOB_READY on handle 0
>> TEST iotest-qcow2: 158
>>
>>
>> thanks
>> -- PMM
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: various iotests failures apparently due to overly optimistic timeout settings
2020-07-20 14:12 ` John Snow
@ 2020-07-20 14:15 ` Peter Maydell
2020-07-20 14:18 ` John Snow
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2020-07-20 14:15 UTC (permalink / raw)
To: John Snow; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On Mon, 20 Jul 2020 at 15:12, John Snow <jsnow@redhat.com> wrote:
>
> On 7/20/20 6:46 AM, Kevin Wolf wrote:
> > John, I think this is a result of your recent python/qemu/ changes that
> > make failure of graceful shutdown an error rather than just silently
> > falling back to SIGKILL.
> >
> > Should the default timeout be longer, should iotests override the
> > default, or should iotests just always kill their VM instead of trying
> > to shut it down gracefully?
> Let's make it longer. Since you are seeing the failures, can you edit
> python/qemu/machine.py and find the default timeout of 3 seconds for
> shutdown() and change it to 10? 30? 60?
Not conveniently, because this is for merge pull requests, and
all the iotests failures are nested inside the tests/vm BSD VM
setup.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: various iotests failures apparently due to overly optimistic timeout settings
2020-07-20 14:15 ` Peter Maydell
@ 2020-07-20 14:18 ` John Snow
2020-07-20 14:21 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: John Snow @ 2020-07-20 14:18 UTC (permalink / raw)
To: Peter Maydell; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On 7/20/20 10:15 AM, Peter Maydell wrote:
> On Mon, 20 Jul 2020 at 15:12, John Snow <jsnow@redhat.com> wrote:
>>
>> On 7/20/20 6:46 AM, Kevin Wolf wrote:
>>> John, I think this is a result of your recent python/qemu/ changes that
>>> make failure of graceful shutdown an error rather than just silently
>>> falling back to SIGKILL.
>>>
>>> Should the default timeout be longer, should iotests override the
>>> default, or should iotests just always kill their VM instead of trying
>>> to shut it down gracefully?
>
>> Let's make it longer. Since you are seeing the failures, can you edit
>> python/qemu/machine.py and find the default timeout of 3 seconds for
>> shutdown() and change it to 10? 30? 60?
>
> Not conveniently, because this is for merge pull requests, and
> all the iotests failures are nested inside the tests/vm BSD VM
> setup.
I meant permanently, for everything -- not as a one-off for just this case.
--js
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: various iotests failures apparently due to overly optimistic timeout settings
2020-07-20 14:18 ` John Snow
@ 2020-07-20 14:21 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2020-07-20 14:21 UTC (permalink / raw)
To: John Snow; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On Mon, 20 Jul 2020 at 15:18, John Snow <jsnow@redhat.com> wrote:
>
> On 7/20/20 10:15 AM, Peter Maydell wrote:
> > On Mon, 20 Jul 2020 at 15:12, John Snow <jsnow@redhat.com> wrote:
> >>
> >> On 7/20/20 6:46 AM, Kevin Wolf wrote:
> >>> John, I think this is a result of your recent python/qemu/ changes that
> >>> make failure of graceful shutdown an error rather than just silently
> >>> falling back to SIGKILL.
> >>>
> >>> Should the default timeout be longer, should iotests override the
> >>> default, or should iotests just always kill their VM instead of trying
> >>> to shut it down gracefully?
> >
> >> Let's make it longer. Since you are seeing the failures, can you edit
> >> python/qemu/machine.py and find the default timeout of 3 seconds for
> >> shutdown() and change it to 10? 30? 60?
> >
> > Not conveniently, because this is for merge pull requests, and
> > all the iotests failures are nested inside the tests/vm BSD VM
> > setup.
>
> I meant permanently, for everything -- not as a one-off for just this case.
Can't conveniently do that either, because the merge build runs on
head-of-master plus the thing being merged, so it won't have local
edits to machine.py in it, only the version that's in master.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-20 14:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-19 12:07 various iotests failures apparently due to overly optimistic timeout settings Peter Maydell
2020-07-20 10:46 ` Kevin Wolf
2020-07-20 14:12 ` John Snow
2020-07-20 14:15 ` Peter Maydell
2020-07-20 14:18 ` John Snow
2020-07-20 14:21 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).