From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82B1CC6FD18 for ; Tue, 25 Apr 2023 09:22:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prErV-00070y-5O; Tue, 25 Apr 2023 05:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prErT-00070F-GR for qemu-devel@nongnu.org; Tue, 25 Apr 2023 05:21:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prErO-0004wi-Py for qemu-devel@nongnu.org; Tue, 25 Apr 2023 05:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682414477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MN9oXgsc8DHoo1VpyjDGkHB8D0MhxIlnzkrg3+EvyyI=; b=aGZ/on9nG7bNvfy4DgDwdXyl2eiDNRTiS9i1y14j2wViga5oKgERkrCFDRMJN44KB2e8UU 3t4KhJPrsTg2sgVX6OZ2A2F5ELGdj7p7bm4nrPDMjBzGyAc/6dR3RxuhPiSaqjq7aZYrMd hg1nwNyXajOMujNo9ANVBBNb3gh0P8w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-N4MEh54eOPS9-N_HWvFrVA-1; Tue, 25 Apr 2023 05:21:16 -0400 X-MC-Unique: N4MEh54eOPS9-N_HWvFrVA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f18b63229bso53597665e9.0 for ; Tue, 25 Apr 2023 02:21:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682414475; x=1685006475; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MN9oXgsc8DHoo1VpyjDGkHB8D0MhxIlnzkrg3+EvyyI=; b=JfBPZBX8yqL7d52iPgdcR0XlvnmGXFDnbXpPmhB3VLJLNPk71csdudaNYsGUxI8yIB CxZjA7h7B7TYwE0xq9WDgoI8QA5r+v9RvasE1XtKgZAPjrj4EgfQ0o5jfiNb7PLGbNtZ 1H/iiS9IfSPkzQfHJG+h1SmuZsWJ90eHwNMKb2NVZbZwpzV5ktFQUiAvFg1yr2ZNrYN1 4n1UbGt3MOOl+JMEd7b9UM9lvfZqjkVrVhiPOx4I4HM0wBZhVSIpDNjmyP72578ugpyo LSaC3JI4ySTgHw5uiqC3OHq5BnjFXR/Rv1NLnLNDC1aBDyRl7qeHvcnrvEYdKzRxIpC6 vOzA== X-Gm-Message-State: AAQBX9d3ypZztNDh7GrFsx1mum/NRwUtUrdheCmZPZf3KjS6815Hmvv1 bmp6bY+pDd3SkEegO5i12GvGt5A8dmo7T1tLDOc9x2rSXTCVqiHoddzvM31mjZjfWbuOk5NpcQ9 AZ+i/dDynK8NI0eI= X-Received: by 2002:a1c:4c13:0:b0:3f1:72f2:25c4 with SMTP id z19-20020a1c4c13000000b003f172f225c4mr9575509wmf.13.1682414474861; Tue, 25 Apr 2023 02:21:14 -0700 (PDT) X-Google-Smtp-Source: AKy350ZLuSp7XDFOpHgXeBZjKve/FX0TjkCPYNbEdM9TBWh3dDFfTkStP/iM10UGGNvuhPtP6ffuJg== X-Received: by 2002:a1c:4c13:0:b0:3f1:72f2:25c4 with SMTP id z19-20020a1c4c13000000b003f172f225c4mr9575496wmf.13.1682414474606; Tue, 25 Apr 2023 02:21:14 -0700 (PDT) Received: from [10.33.192.205] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id m7-20020a5d4a07000000b002c55521903bsm12609942wrq.51.2023.04.25.02.21.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 02:21:14 -0700 (PDT) Message-ID: <90e96d55-fc8b-52ec-6747-4fecd10e9e10@redhat.com> Date: Tue, 25 Apr 2023 11:21:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] aspeed/hace: Initialize g_autofree pointer Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, Peter Maydell , Andrew Jeffery , Steven Lee , Joel Stanley , QEMU Trivial References: <20230421131547.2177449-1-clg@kaod.org> From: Thomas Huth In-Reply-To: <20230421131547.2177449-1-clg@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.194, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21/04/2023 15.15, Cédric Le Goater wrote: > As mentioned in docs/devel/style.rst "Automatic memory deallocation": > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > This avoids QEMU to coredump when running the "hash test" command > under Zephyr. > > Cc: Steven Lee > Cc: Joel Stanley > Fixes: c5475b3f9a ("hw: Model ASPEED's Hash and Crypto Engine") > Signed-off-by: Cédric Le Goater > --- > hw/misc/aspeed_hace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c > index 12a761f1f5..b07506ec04 100644 > --- a/hw/misc/aspeed_hace.c > +++ b/hw/misc/aspeed_hace.c > @@ -189,7 +189,7 @@ static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode, > bool acc_mode) > { > struct iovec iov[ASPEED_HACE_MAX_SG]; > - g_autofree uint8_t *digest_buf; > + g_autofree uint8_t *digest_buf = NULL; We maybe need a checkpatch.pl rule to catch such bugs... Reviewed-by: Thomas Huth