From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] accel/tcg: Align data dumped at end of TB
Date: Sun, 16 May 2021 09:01:39 -0500 [thread overview]
Message-ID: <90edde1e-b429-0364-8507-d760be8ed1fe@linaro.org> (raw)
In-Reply-To: <20210515104202.241504-1-f4bug@amsat.org>
On 5/15/21 5:42 AM, Philippe Mathieu-Daudé wrote:
> + qemu_log("0x%08" PRIxPTR ": .quad 0x%0*" TCG_PRIlx "\n",
> + (uintptr_t)&rx_data_gen_ptr[i],
> + 2 * sizeof(tcg_target_ulong), rx_data_gen_ptr[i]);
This doesn't quite work, because
> ../qemu/accel/tcg/translate-all.c:2045:26: error: field width specifier ‘*’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Werror=format=]
> 2045 | qemu_log("0x%08" PRIxPTR ": .quad 0x%0*" TCG_PRIlx "\n",
> | ^~~~~~~
> 2046 | (uintptr_t)&rx_data_gen_ptr[i],
> 2047 | 2 * sizeof(tcg_target_ulong), rx_data_gen_ptr[i]);
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | long unsigned int
However, I also noticed that we shouldn't be printing ".quad" for 32-bit hosts
either. So I'll just split this into two separate qemu_log invocations, based
on sizeof(tcg_target_ulong).
r~
next prev parent reply other threads:[~2021-05-16 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 10:42 [PATCH] accel/tcg: Align data dumped at end of TB Philippe Mathieu-Daudé
2021-05-16 14:01 ` Richard Henderson [this message]
2021-05-16 17:54 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90edde1e-b429-0364-8507-d760be8ed1fe@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).