From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x <qemu-s390x@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: compile warning in i8259.c
Date: Mon, 15 Mar 2021 10:27:12 -0600 [thread overview]
Message-ID: <91094e63-a7e9-7513-f42f-deba1556b58a@linaro.org> (raw)
In-Reply-To: <8ba68f46-3bd8-b8ee-b45d-4f3235b38583@redhat.com>
On 3/15/21 10:20 AM, Thomas Huth wrote:
> + if (irq == 2) {
> + irq2 = pic_get_irq(slave_pic);
This looks better. You should also be able to pull in the declaration to
int irq2 = pic_get_irq(slave_pic);
here.
r~
next prev parent reply other threads:[~2021-03-15 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 15:14 compile warning in i8259.c Christian Borntraeger
2021-03-15 15:42 ` Thomas Huth
2021-03-15 15:46 ` Christian Borntraeger
2021-03-15 15:50 ` Philippe Mathieu-Daudé
2021-03-15 15:58 ` Thomas Huth
2021-03-15 16:15 ` Christian Borntraeger
2021-03-15 15:44 ` Christian Borntraeger
2021-03-15 15:55 ` Philippe Mathieu-Daudé
2021-03-15 16:43 ` Paolo Bonzini
2021-03-15 16:20 ` Thomas Huth
2021-03-15 16:27 ` Richard Henderson [this message]
2021-03-15 16:27 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91094e63-a7e9-7513-f42f-deba1556b58a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).