* [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() @ 2023-06-08 9:07 ~foxes 2023-06-08 9:06 ` [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer ~foxes 2023-06-20 7:30 ` [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() Richard Henderson 0 siblings, 2 replies; 4+ messages in thread From: ~foxes @ 2023-06-08 9:07 UTC (permalink / raw) To: qemu-devel; +Cc: Alex Bennée From: Foxes Hung <foxes687@andestech.com> Signed-off-by: Foxes Hung <foxes687@andestech.com> --- semihosting/syscalls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c index 68899ebb1c..1a5d39da01 100644 --- a/semihosting/syscalls.c +++ b/semihosting/syscalls.c @@ -281,6 +281,9 @@ static void host_open(CPUState *cs, gdb_syscall_complete_cb complete, if (gdb_flags & GDB_O_TRUNC) { host_flags |= O_TRUNC; } + if (gdb_flags & GDB_O_APPEND) { + host_flags |= O_APPEND; + } if (gdb_flags & GDB_O_EXCL) { host_flags |= O_EXCL; } -- 2.38.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer 2023-06-08 9:07 [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() ~foxes @ 2023-06-08 9:06 ` ~foxes 2023-06-20 7:32 ` Richard Henderson 2023-06-20 7:30 ` [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() Richard Henderson 1 sibling, 1 reply; 4+ messages in thread From: ~foxes @ 2023-06-08 9:06 UTC (permalink / raw) To: qemu-devel; +Cc: Alex Bennée From: Foxes Hung <foxes687@andestech.com> Signed-off-by: Foxes Hung <foxes687@andestech.com> --- gdbstub/syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c index 02e3a8f74c..4c6b5f728b 100644 --- a/gdbstub/syscalls.c +++ b/gdbstub/syscalls.c @@ -126,7 +126,7 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...) case 's': i64 = va_arg(va, uint64_t); i32 = va_arg(va, uint32_t); - p += snprintf(p, p_end - p, "%" PRIx64 "/%x" PRIx32, i64, i32); + p += snprintf(p, p_end - p, "%" PRIx64 "/%" PRIx32, i64, i32); break; default: bad_format: -- 2.38.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer 2023-06-08 9:06 ` [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer ~foxes @ 2023-06-20 7:32 ` Richard Henderson 0 siblings, 0 replies; 4+ messages in thread From: Richard Henderson @ 2023-06-20 7:32 UTC (permalink / raw) To: ~foxes, qemu-devel; +Cc: Alex Bennée On 6/8/23 11:06, ~foxes wrote: > From: Foxes Hung <foxes687@andestech.com> > > Signed-off-by: Foxes Hung <foxes687@andestech.com> > --- > gdbstub/syscalls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c > index 02e3a8f74c..4c6b5f728b 100644 > --- a/gdbstub/syscalls.c > +++ b/gdbstub/syscalls.c > @@ -126,7 +126,7 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char *fmt, ...) > case 's': > i64 = va_arg(va, uint64_t); > i32 = va_arg(va, uint32_t); > - p += snprintf(p, p_end - p, "%" PRIx64 "/%x" PRIx32, i64, i32); > + p += snprintf(p, p_end - p, "%" PRIx64 "/%" PRIx32, i64, i32); > break; > default: > bad_format: Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() 2023-06-08 9:07 [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() ~foxes 2023-06-08 9:06 ` [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer ~foxes @ 2023-06-20 7:30 ` Richard Henderson 1 sibling, 0 replies; 4+ messages in thread From: Richard Henderson @ 2023-06-20 7:30 UTC (permalink / raw) To: ~foxes, qemu-devel; +Cc: Alex Bennée On 6/8/23 11:07, ~foxes wrote: > From: Foxes Hung <foxes687@andestech.com> > > Signed-off-by: Foxes Hung <foxes687@andestech.com> > --- > semihosting/syscalls.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/semihosting/syscalls.c b/semihosting/syscalls.c > index 68899ebb1c..1a5d39da01 100644 > --- a/semihosting/syscalls.c > +++ b/semihosting/syscalls.c > @@ -281,6 +281,9 @@ static void host_open(CPUState *cs, gdb_syscall_complete_cb complete, > if (gdb_flags & GDB_O_TRUNC) { > host_flags |= O_TRUNC; > } > + if (gdb_flags & GDB_O_APPEND) { > + host_flags |= O_APPEND; > + } > if (gdb_flags & GDB_O_EXCL) { > host_flags |= O_EXCL; > } Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-20 7:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-08 9:07 [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() ~foxes 2023-06-08 9:06 ` [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer ~foxes 2023-06-20 7:32 ` Richard Henderson 2023-06-20 7:30 ` [PATCH qemu 1/2] semihosting: Added to support GDB_O_APPEND flag of host_open() Richard Henderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).