From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRFwp-0004Fc-3K for qemu-devel@nongnu.org; Tue, 19 Dec 2017 06:20:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRFwk-0004wC-4P for qemu-devel@nongnu.org; Tue, 19 Dec 2017 06:20:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRFwj-0004u9-Ue for qemu-devel@nongnu.org; Tue, 19 Dec 2017 06:20:30 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68BEE7F41D for ; Tue, 19 Dec 2017 11:20:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EDE4922FA for ; Tue, 19 Dec 2017 11:20:28 +0000 (UTC) Date: Tue, 19 Dec 2017 06:20:27 -0500 (EST) From: Frediano Ziglio Message-ID: <911826618.967890.1513682427088.JavaMail.zimbra@redhat.com> In-Reply-To: <2083994092.34289761.1512637514012.JavaMail.zimbra@redhat.com> References: <20171122135625.16625-1-fziglio@redhat.com> <2083994092.34289761.1512637514012.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kraxel@redhat.com Cc: qemu-devel@nongnu.org ping > > ping the series > > > > > This fields points to an old interface that is no more > > used in the current code. > > > > Signed-off-by: Frediano Ziglio > > --- > > hw/display/qxl.c | 1 - > > include/ui/spice-display.h | 1 - > > ui/spice-display.c | 2 -- > > 3 files changed, 4 deletions(-) > > > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > > index 99365c3e8f..b9fa067f6e 100644 > > --- a/hw/display/qxl.c > > +++ b/hw/display/qxl.c > > @@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, > > QXLWorker *qxl_worker) > > PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); > > > > trace_qxl_interface_attach_worker(qxl->id); > > - qxl->ssd.worker = qxl_worker; > > } > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > > index aaf2019889..6b5c73b21c 100644 > > --- a/include/ui/spice-display.h > > +++ b/include/ui/spice-display.h > > @@ -86,7 +86,6 @@ struct SimpleSpiceDisplay { > > DisplayChangeListener dcl; > > void *buf; > > int bufsize; > > - QXLWorker *worker; > > QXLInstance qxl; > > uint32_t unique; > > pixman_image_t *surface; > > diff --git a/ui/spice-display.c b/ui/spice-display.c > > index ad1ceafb3f..85a72fe76a 100644 > > --- a/ui/spice-display.c > > +++ b/ui/spice-display.c > > @@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, > > QXLWorker *qxl_worker) > > SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, qxl); > > > > dprint(1, "%s/%d:\n", __func__, ssd->qxl.id); > > - ssd->worker = qxl_worker; > > } > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > @@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole > > *con) > > > > ssd->qxl.base.sif = &dpy_interface.base; > > qemu_spice_add_display_interface(&ssd->qxl, con); > > - assert(ssd->worker); > > qemu_spice_create_host_memslot(ssd); > > > > register_displaychangelistener(&ssd->dcl); > >