From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3fHb-0001kk-TN for qemu-devel@nongnu.org; Fri, 20 May 2016 03:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3fHX-0005ON-HE for qemu-devel@nongnu.org; Fri, 20 May 2016 03:55:42 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3fHX-0005NR-6d for qemu-devel@nongnu.org; Fri, 20 May 2016 03:55:39 -0400 Received: by mail-wm0-x232.google.com with SMTP id n129so69764016wmn.1 for ; Fri, 20 May 2016 00:55:39 -0700 (PDT) Sender: Paolo Bonzini References: <1463142777-13040-1-git-send-email-kraxel@redhat.com> <1463142777-13040-17-git-send-email-kraxel@redhat.com> From: Paolo Bonzini Message-ID: <912bd9ff-6add-5536-e041-9a2f56e5322b@redhat.com> Date: Fri, 20 May 2016 09:55:36 +0200 MIME-Version: 1.0 In-Reply-To: <1463142777-13040-17-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org On 13/05/2016 14:32, Gerd Hoffmann wrote: > @@ -1442,14 +1474,19 @@ static void gd_grab_pointer(VirtualConsole *vc, const char *reason) > static void gd_ungrab_pointer(GtkDisplayState *s) > { > VirtualConsole *vc = s->ptr_owner; > + GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area); > > if (vc == NULL) { > return; > } Unnecessary vc == NULL check, or possible NULL pointer dereference in the assignment to display? (Spotted by Coverity). Thanks, Paolo > s->ptr_owner = NULL; > > - GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);