From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DB2C47404 for ; Wed, 9 Oct 2019 23:03:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2018206BB for ; Wed, 9 Oct 2019 23:03:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=digitalocean.com header.i=@digitalocean.com header.b="hzoYwha2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2018206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=digitalocean.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIKzK-0006S0-Q5 for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 19:03:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIKxu-0005dw-IL for qemu-devel@nongnu.org; Wed, 09 Oct 2019 19:01:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIKxt-0001Gx-6H for qemu-devel@nongnu.org; Wed, 09 Oct 2019 19:01:54 -0400 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:40816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIKxt-0001Gb-1I for qemu-devel@nongnu.org; Wed, 09 Oct 2019 19:01:53 -0400 Received: by mail-qk1-x744.google.com with SMTP id y144so3822126qkb.7 for ; Wed, 09 Oct 2019 16:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digitalocean.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B21mcGjow+HfA5VcpPRsbfHtSTTRAoaikUCR4Luqd6Y=; b=hzoYwha2tyyZNabISe7F4a7nWEGAw2Whrul2jdt+f3Y0GkfU63QKM36ffnM0dz/1zD MDwjyGtRdCz1ND5SwIoWpdYDSL2ocfIl5s9y7XewCDOh1iHHFqyQSKczph2fd3ZpYq5F BG9cNKM4Xssr2iPgn/23Pkad+h2F1bH9opI+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B21mcGjow+HfA5VcpPRsbfHtSTTRAoaikUCR4Luqd6Y=; b=dphL7S06ZhQQK9GshI1NTNkTMCFQAW83cyemX3dLeTt1teE+Y6meoBQYdjACGEdpBe ygVm3nrSy/V1tG9M5KTcGmXD/dHkl+vvlzmb7EvLZPMzJAYztIjRlhrYO8U4TIBYNXr8 Y39DwX4FadiLzFUwepz0CDYDc7oZZXlU7ltv1XLTKoQK0N9YLE4EXgRGUsV1hkHK6cWX fTB9NeFM2Ugji/Vl1IDQogARUO9T41EkUhaICs5z8pxkI2vXYocjjM0Nc97nwDImnqvx zbsczCY74/57SGYGiYsXRTntOb+sAtXFa4piWOoaLKE2iP6QnlZ5sNqV90wmwf9rBetV PKmw== X-Gm-Message-State: APjAAAX39v69UG7SemUbHkCbbd3Ke/pLSrSRtQGfuEkTb/GUScd7YN7x Ds67QjsJtN2ipYGJX74YJzsCHg== X-Google-Smtp-Source: APXvYqyfrUWn4twJrb2+/FU7qhzh3QlnaIj29vFfwwCY2evpZmd2s0EQXg4Vz1YRoctz0FbGy4J78g== X-Received: by 2002:a37:9d85:: with SMTP id g127mr6130448qke.158.1570662112111; Wed, 09 Oct 2019 16:01:52 -0700 (PDT) Received: from ?IPv6:2600:1700:4a30:84c0:8d5e:794e:8a2e:ee89? ([2600:1700:4a30:84c0:8d5e:794e:8a2e:ee89]) by smtp.gmail.com with ESMTPSA id 77sm1854333qke.78.2019.10.09.16.01.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 16:01:51 -0700 (PDT) Subject: Re: [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs To: Paolo Bonzini , philmd@redhat.com, mtosatti@redhat.com, armbru@redhat.com Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, rth@twiddle.net, ehabkost@redhat.com References: <20191009164459.8209-1-msmarduch@digitalocean.com> <71149051-f7b9-b3ef-8493-4e2db1644a8d@redhat.com> From: Mario Smarduch Message-ID: <913c58df-73ef-8edb-94d5-aeb191ab806c@digitalocean.com> Date: Wed, 9 Oct 2019 16:01:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <71149051-f7b9-b3ef-8493-4e2db1644a8d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::744 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/09/2019 02:19 PM, Paolo Bonzini wrote: > On 09/10/19 18:44, Mario Smarduch wrote: >> In a large VPC environment we want to log memory error occurrences >> and log them with guest name and type - there are few use cases >> >> >> - if VM crashes on AR mce inform the user about the reason and resolve the case >> - if VM hangs notify the user to reboot and resume processing >> - if VM continues to run let the user know, he/she maybe able to correlate >> to vm internal outage >> - Rawhammer attacks - isolate/determine the attacker possible migrating it off >> the hypervisor >> - In general track memory errors on a hyperviosr over time to determine trends >> >> Monitoring our fleet we come across quite a few of these and been >> able to take action where before there were no clues to the causes. >> >> When memory error occurs we get a log entry in qemu log: >> >> Guest [Droplet-12345678] 2019-08-02T05:00:11.940270Z qemu-system-x86_64: >> Guest MCE Memory Error at QEMU addr 0x7f3c7622f000 and GUEST 0x78e42f000 >> addr of type BUS_MCEERR_AR injected >> >> with enterprise logging environment we can to take further actions. >> >> v1 -> v2: >> - split into two patches one to get the gustname second to log MCEs >> - addressed comments for MCE logging >> >> Mario Smarduch (2): >> util/qemu-error: add guest name helper with -msg options >> target/i386: log MCE guest and host addresses >> >> include/qemu/error-report.h | 1 + >> qemu-options.hx | 10 ++++++---- >> target/i386/kvm.c | 29 ++++++++++++++++++++++++----- >> util/qemu-error.c | 31 +++++++++++++++++++++++++++++++ >> vl.c | 5 +++++ >> 5 files changed, 67 insertions(+), 9 deletions(-) >> > > Queued, thanks. > > Paolo > Great, thanks for the fixup and y'all time. - Mario