From: Richard Henderson <richard.henderson@linaro.org>
To: Jordan Niethe <jniethe5@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bgray@linux.ibm.com,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 2/7] tcg/ppc: Use PADDI in tcg_out_movi
Date: Mon, 7 Aug 2023 14:26:23 -0700 [thread overview]
Message-ID: <91548e24-16e0-d177-c4fe-2a3d98f76ee8@linaro.org> (raw)
In-Reply-To: <CACzsE9r1w2TQ9-587g7CCZOzjE2bsnQch6Xe3LC6binDEkB1jQ@mail.gmail.com>
On 8/6/23 20:53, Jordan Niethe wrote:
>> + tmp = tcg_out_need_prefix_align(s) * 4;
>
> tcg_out_need_prefix_align() returns a bool, optionally might prefer
>
> tmp = tcg_out_need_prefix_align(s) ? 4 : 0;
I suppose. C type promotion rules make the multiplication just the same though.
That said, I've merged back Nick's tcg_pcrel_diff_for_prefix function using ?:.
r~
next prev parent reply other threads:[~2023-08-07 21:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 21:33 [PATCH for-8.2 0/7] tcg/ppc: Support power10 prefixed instructions Richard Henderson
2023-08-04 21:33 ` [PATCH 1/7] tcg/ppc: Untabify tcg-target.c.inc Richard Henderson
2023-08-04 21:33 ` [PATCH 2/7] tcg/ppc: Use PADDI in tcg_out_movi Richard Henderson
2023-08-07 3:53 ` Jordan Niethe
2023-08-07 21:26 ` Richard Henderson [this message]
2023-08-04 21:33 ` [PATCH 3/7] tcg/ppc: Use prefixed instructions in tcg_out_mem_long Richard Henderson
2023-08-07 3:51 ` Jordan Niethe
2023-08-04 21:33 ` [PATCH 4/7] tcg/ppc: Use PLD in tcg_out_movi for constant pool Richard Henderson
2023-08-04 21:33 ` [PATCH 5/7] tcg/ppc: Use prefixed instructions in tcg_out_dupi_vec Richard Henderson
2023-08-04 21:33 ` [PATCH 6/7] tcg/ppc: Disable USE_REG_TB for Power v3.1 Richard Henderson
2023-08-06 11:58 ` Nicholas Piggin
2023-08-06 13:45 ` Richard Henderson
2023-08-04 21:33 ` [PATCH 7/7] tcg/ppc: Use prefixed instructions for tcg_out_goto_tb Richard Henderson
2023-08-06 12:55 ` Nicholas Piggin
2023-08-06 14:13 ` Richard Henderson
2023-08-07 1:51 ` Nicholas Piggin
2023-08-07 7:29 ` Nicholas Piggin
2023-08-07 9:38 ` Nicholas Piggin
2023-08-07 4:08 ` Jordan Niethe
2023-08-06 11:55 ` [PATCH for-8.2 0/7] tcg/ppc: Support power10 prefixed instructions Nicholas Piggin
2023-08-06 14:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91548e24-16e0-d177-c4fe-2a3d98f76ee8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bgray@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).