From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF88C3E8C5 for ; Fri, 27 Nov 2020 18:31:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 674E421534 for ; Fri, 27 Nov 2020 18:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BLBzbNMQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 674E421534 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiiWN-0007w4-1t for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 13:31:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiiV9-0007On-Uo for qemu-devel@nongnu.org; Fri, 27 Nov 2020 13:29:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiiV6-0007Bc-Im for qemu-devel@nongnu.org; Fri, 27 Nov 2020 13:29:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606501783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c95/BQD1reQkyYDwgTsy9qz62mODFanT+OiCLgDY0z8=; b=BLBzbNMQtSV/I2eqxyFsUP2bSyuoOq0Moe61G51RDsDLfWIp9Kqdbnpyrtv50ttALSZHNv ekGZ8NtAZiLYI5SGbRn6EaDDozUQrvk5T/ToTuu47mMtdmEnizCxwW4sGmOKqQMXBbXw52 NcpJER9XtU9TdB723AQxeXOiLgmePUE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-kXflL9XMPHOnMB4oQYAM_g-1; Fri, 27 Nov 2020 13:29:41 -0500 X-MC-Unique: kXflL9XMPHOnMB4oQYAM_g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FBDA802B48; Fri, 27 Nov 2020 18:29:40 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-70.ams2.redhat.com [10.36.113.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 770BC60BF1; Fri, 27 Nov 2020 18:29:32 +0000 (UTC) Subject: Re: [RFC PATCH-for-5.2] gitlab-ci: Do not automatically run Avocado integration tests anymore To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Willian Rampazzo References: <20201127174110.1932671-1-philmd@redhat.com> From: Thomas Huth Message-ID: <9157dce0-4f5d-3f1e-ce75-3e9da9252203@redhat.com> Date: Fri, 27 Nov 2020 19:29:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , virt-ci-maint-team@redhat.com, Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 27/11/2020 18.57, Philippe Mathieu-Daudé wrote: > On 11/27/20 6:47 PM, Thomas Huth wrote: >> On 27/11/2020 18.41, Philippe Mathieu-Daudé wrote: >>> We lately realized that the Avocado framework was not designed >>> to be regularly run on CI environments. Therefore, as of 5.2 >>> we deprecate the gitlab-ci jobs using Avocado. To not disrupt >>> current users, it is possible to keep the current behavior by >>> setting the QEMU_CI_INTEGRATION_JOBS_PRE_5_2_RELEASE variable >>> (see [*]). >>> From now on, using these jobs (or adding new tests to them) >>> is strongly discouraged. >>> >>> Tests based on Avocado will be ported to new job schemes during >>> the next releases, with better documentation and templates. >> >> Why should we disable the jobs by default as long as there is no replacement >> available yet? > > Why keep it enabled if it is failing randomly We can still disable single jobs if they are not stable, but that's no reason to disable all of them by default, is it? > if images hardcoded > in tests are being removed from public servers, etc...? That's independent from Avocado, you'll always have that problem if you want to test with external images, unless you mirror them into a repository on the same server (ie. gitlab), which, however, might not always be possible... > They are not disabled, they are still runnable manually or setting > QEMU_CI_INTEGRATION_JOBS_PRE_5_2_RELEASE... And who do you think is going to set that variable? Hardly anybody, I guess. So you could also simply remove the stuff from the yml file completely instead. > We realized by default Avocado runs all tests on the CI jobs, > triggering failures and complains. Developer stopped to contribute/ > review integration tests because of that. Did anybody really stop contributing "acceptance" test since they were afraid of the gitlab-CI running them? That's new to me, do you have a pointer? > We want developers be > able to contribute tests to the repository fearlessly. You can always mark your test with @skipIf(os.getenv('GITLAB_CI')) if you don't want to see it running in the gitlab-CI, so that's not a reason to be afraid. > If we don't change anything, we'll keep having CI failures due > to Avocado design issues (artifacts removed from remote servers, > etc...). I fail to see the relation between Avocado and vanishing artifacts from 3rd party servers... what do you plan to do instead if something gets (re-)moved from a server that is not under our control? > I haven't seen any attempt on this list to improve the current > fragile situation, but better suggestions are certainly welcome. At least I am hoping that the "check-acceptance" tests will break a little bit less often once Peter uses the gitlab-CI for his gating tests, too. That will at least prevent that one of the tests gets completely broken by a new merged pull request. Of course there's still the risk that tests only fail occasionally due to new bugs, but that can also happen for all other test suites (unit, qtest, iotests, ...), too. Thomas