From: Paolo Bonzini <pbonzini@redhat.com>
To: Bob Breuer <breuerr@mc.net>
Cc: "C.W. Betts" <computers57@hotmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch]Make GTK build on OS X
Date: Thu, 28 Mar 2013 02:21:00 -0400 (EDT) [thread overview]
Message-ID: <916700687.16383315.1364451660518.JavaMail.root@redhat.com> (raw)
In-Reply-To: <51534CF1.5080506@mc.net>
> > Yes, I know. The point is that there's already an idiom to choose
> > between pty.h/util.h/libutil.h, and we should not introduce
> > another.
>
> Note that mingw has none of those headers, so double-check the _WIN32
> conditionals.
Good catch. C.W., the right include file is include/sysemu/os-posix.h.
My mistake, sorry.
Paolo
> >
> > Paolo
> >
> >>>
> >>> #if defined(__GLIBC__)
> >>> #include <pty.h>
> >>> #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
> >>> defined(__DragonFly__)
> >>> #include <libutil.h>
> >>> #else
> >>> #include <util.h>
> >>> #endif
> >>>
> >>> Please move it to include/qemu-common.h instead so that there is
> >>> no
> >>> duplication.
> >> The next patch will do this. Thank you for the feedback.
> >>>
> >>> Paolo
> >>>
> >>
> >>
> >
> >
> >
> >
>
>
prev parent reply other threads:[~2013-03-28 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 22:16 [Qemu-devel] [patch]Make GTK build on OS X C.W. Betts
2013-03-27 8:34 ` Paolo Bonzini
2013-03-27 18:05 ` C.W. Betts
2013-03-27 18:34 ` Paolo Bonzini
2013-03-27 19:48 ` Bob Breuer
2013-03-28 6:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916700687.16383315.1364451660518.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=breuerr@mc.net \
--cc=computers57@hotmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).