From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UL6Cu-0005qm-RL
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 02:21:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UL6Cs-0001DI-W1
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 02:21:04 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:44630)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UL6Cs-0001Cw-Mo
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 02:21:02 -0400
Date: Thu, 28 Mar 2013 02:21:00 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <916700687.16383315.1364451660518.JavaMail.root@redhat.com>
In-Reply-To: <51534CF1.5080506@mc.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [patch]Make GTK build on OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bob Breuer <breuerr@mc.net>
Cc: "C.W. Betts" <computers57@hotmail.com>, qemu-devel@nongnu.org


> > Yes, I know.  The point is that there's already an idiom to choose
> > between pty.h/util.h/libutil.h, and we should not introduce
> > another.
> 
> Note that mingw has none of those headers, so double-check the _WIN32
> conditionals.

Good catch.  C.W., the right include file is include/sysemu/os-posix.h.
My mistake, sorry.

Paolo

> > 
> > Paolo
> > 
> >>>
> >>> #if defined(__GLIBC__)
> >>> #include <pty.h>
> >>> #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
> >>> defined(__DragonFly__)
> >>> #include <libutil.h>
> >>> #else
> >>> #include <util.h>
> >>> #endif
> >>>
> >>> Please move it to include/qemu-common.h instead so that there is
> >>> no
> >>> duplication.
> >> The next patch will do this. Thank you for the feedback.
> >>>
> >>> Paolo
> >>>
> >>
> >>
> > 
> > 
> > 
> > 
> 
>