From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89A5FCA0FED for ; Tue, 9 Sep 2025 10:18:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvvQ0-0007w1-Vt; Tue, 09 Sep 2025 06:17:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvvPt-0007oj-Ch for qemu-devel@nongnu.org; Tue, 09 Sep 2025 06:17:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvvPq-0005wp-D8 for qemu-devel@nongnu.org; Tue, 09 Sep 2025 06:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757413051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8WmOzYXodsSBYYeCMbLmze/pZqfbcZKz+Ub5/20ryAo=; b=CRaDSploqNHMnZBVJT36Co+drWg4hMXSVTHXrcH3ZeP5l3NVw91BJtehVsSILcXaHIthNE TJY6iRzILTNNPPlfDMcRK5yrtaHQ1trARwXyJmzakFzuI0F5pBdOHfV1f5nihasZLnUbCV f4DkILuVWfVMR+muU8XuaEKZy2RJkxI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-zwXMCpnzOGmCoOMslvR0Jg-1; Tue, 09 Sep 2025 06:17:30 -0400 X-MC-Unique: zwXMCpnzOGmCoOMslvR0Jg-1 X-Mimecast-MFC-AGG-ID: zwXMCpnzOGmCoOMslvR0Jg_1757413049 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3dc3f943e6eso3422062f8f.2 for ; Tue, 09 Sep 2025 03:17:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757413049; x=1758017849; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8WmOzYXodsSBYYeCMbLmze/pZqfbcZKz+Ub5/20ryAo=; b=n4/dvkUjc1gYihbUVOv7XI59LfqPFnS72R8csh+O4HrA42wGOpJUxyTunqqJn53GpJ v6EOu6zwZBygFxrjGeOhJe+8qNsX46/LFiKnC0qxl0gST+IXrDlc5sMnSItvCxsLGMfS Xet9+zErvMJqLE2KxSnPCSFvjvts+ceDUi5+shIPg5LVzrl5wklP5qY35pPveoPHjtHr Fsnt8lU+ABJBTe2kceq0D+PRlr1On8RI1EMD3E+SbsR8xYighh2BlIZ9lG6axuhETEp3 mIID0PJ3LNuTHW3K5wXZEAzLSgVth6knpQvrNuD+HbD9RNLvk44Fx2a1+zbByo3OrCRN G88A== X-Forwarded-Encrypted: i=1; AJvYcCUQ+vPp2eqlOaJVxPvVrMNYlrReZn8Vfb3PFGvGfDuFRdK7OT7K7FW8tijYtMeYm3gCLxeAOsFyl3+G@nongnu.org X-Gm-Message-State: AOJu0Yxnbz3KD5lSXkbAdKIjsuJp3jE/1wQToxY6h+lx+BcFMzkvh7/W kY9WIlBzV2oNPf1VrQ+DOcyfVTo+hAjmYpjTZZT9W2FwUbO9FcurlHYn8O9K2DBhoa+VE9Eiww1 vgaF+pkXna0QQnCjbAgsVn13mk017GP9/FT+5p8nrqFyl3l2dUkrEUTK6 X-Gm-Gg: ASbGncvEtekAAm/umLFmTTpge00F0fOC7J6JbL/jKvuLeHT+jRhT5oOFxa3Im22S7ap GqRUMRosKuEGlqLOq55dZrz8TMDpw2stExJ9Tv12ulIgXBYt1xelIx9z1kfg82vwEs/xWxoPvyC pezCpEdUWXh3WYZc+XYNbHavFJU3VFZukZznuam3Ys4+Sxoqq5a5GOvB59YCZ7FxT6nYgJsCqCN pHqDhxyWNL8sc71UsVAQNSUYYxbmQaAA5TAci136wE9BxJhDAWPQGt9xQ91EbWAF57zYi2l+MAq WsxISYZgfbqnkSxjNl7f2IjL5MaKc90RgNZw6f4ODR3WCOg8kclW6mjKlS+8ZVOpQov4a6GBmao NEAB3Ww== X-Received: by 2002:a5d:5d02:0:b0:3db:c7aa:2c4a with SMTP id ffacd0b85a97d-3e643740fb6mr9710507f8f.42.1757413048739; Tue, 09 Sep 2025 03:17:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHrM6sUSGR2v3DK5CM1rkOjrWdk/UA57/lA/js0MBdgmlf56Z94hx4qmYM4oIsir8SZH3ffNw== X-Received: by 2002:a5d:5d02:0:b0:3db:c7aa:2c4a with SMTP id ffacd0b85a97d-3e643740fb6mr9710482f8f.42.1757413048327; Tue, 09 Sep 2025 03:17:28 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-113-183.pools.arcor-ip.net. [47.64.113.183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7521bf85esm2092568f8f.1.2025.09.09.03.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 03:17:27 -0700 (PDT) Message-ID: <919abc1b-8132-42c6-a3df-9f8c09ce3a0e@redhat.com> Date: Tue, 9 Sep 2025 12:17:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] tests/functional: avoid tearDown failure when QEMU dies To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20250908135722.3375580-1-berrange@redhat.com> <20250908135722.3375580-4-berrange@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250908135722.3375580-4-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 08/09/2025 15.57, Daniel P. Berrangé wrote: > In a QEMU process under test dies unexpectedly, the 'shutdown' > method may well raise an exeception. This causes the tearDown > method to fail, which means any later cleanup code fails to > get run. Most notably the log handlers don't get removed so > the base.log file from an earlier test will get polluted with > messages from any subsequent tests. The tearDown failure also > results in pages of exceptions printed on the console, which > obscures the real failure message / trace printed by the test. > > Ignore any shutdown failures in the tearDown method, since any > test which cares about clean shutdown should have already > cleaned up any running VMs. The tearDown method is just there > as a safety net to cleanup resources. The base.log file will > still containing log messages from the failed 'vm.shutdown' > call too. > > Signed-off-by: Daniel P. Berrangé > --- > tests/functional/qemu_test/testcase.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py > index 82a7724404..faa0a4f0db 100644 > --- a/tests/functional/qemu_test/testcase.py > +++ b/tests/functional/qemu_test/testcase.py > @@ -404,7 +404,10 @@ def set_vm_arg(self, arg, value): > > def tearDown(self): > for vm in self._vms.values(): > - vm.shutdown() > + try: > + vm.shutdown() > + except Exception as ex: > + self.log.error("Failed to teardown VM: %s" % ex) > logging.getLogger('console').removeHandler(self._console_log_fh) > self._console_log_fh.close() > super().tearDown() Reviewed-by: Thomas Huth