From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916C9C48BDF for ; Fri, 18 Jun 2021 16:12:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33AF1613BA for ; Fri, 18 Jun 2021 16:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33AF1613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luH6W-00026L-4M for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 12:12:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luH4K-0007Kh-I0 for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:10:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luH4E-0001On-Hh for qemu-devel@nongnu.org; Fri, 18 Jun 2021 12:10:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624032600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i+6lgn0FAzGAoLDBxGAfYTAFmFGow+LWhk+THwMkDSQ=; b=COZwbhUc7K0+17zWYm7tSPjPPwrrXAUFpaXbAJgJw2Hh6fSzn8Lhc2W+k0AIAtjmpPXs9e peTOda4pmr2MpQF6yyI7tGSgTxYcLZJxcdguDbdnqQrPMg/AMG+aTWu+slMbQzU2tdVbdt 9KCtNmCFxpbWiahjrcriaI2iBkwwJlk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-gxi9p_f_PEaBaKKWXqloFw-1; Fri, 18 Jun 2021 12:09:59 -0400 X-MC-Unique: gxi9p_f_PEaBaKKWXqloFw-1 Received: by mail-wm1-f70.google.com with SMTP id l10-20020a05600c088ab02901d2febdac30so2120575wmp.0 for ; Fri, 18 Jun 2021 09:09:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i+6lgn0FAzGAoLDBxGAfYTAFmFGow+LWhk+THwMkDSQ=; b=qg2Plqxz2VTD9ekzlMlIKa6D90ay3ePZ/ThBAf137E4GnQzSe/bMmqPQ8ornmT8tV8 HbAvJ7dEuVwxGLmPoQD5g/SH6aTNyjy9+tsZ9Tk3Gagxd90kN04HPaH43Qy84OkCDzFF b4CeQMdhnxT/t0tvXsq8kfJxkuMOBgnkx4rEoT32VlfjRyyN/pa76kSb5XqHwl+bzFZM OVoA6N803nKnt62mpkye5zh2RvVOp75vf419J7SDZb4ze17HybCAiXK8g3SCs7mOGj5e 1iFvv32NyU7aBoobz7682I+DpJxlOh9PW5SgAdmg1XoNy/5+8fJy4NKHyUbEsBr3345B ykNw== X-Gm-Message-State: AOAM530Pg9Q4KV6nS+V4Me3JSXfGoNOZISaTZwtwxKOfr3969ejU5uOn 0kHu2i9+5czYZ1SV9CGsFXbThoYVDju+1mV5GE/PwnNfiO+u9QQjxWTN9kv4I7xDdOXY8s4WVpY Uws1fnLMFUGNBCEE= X-Received: by 2002:a7b:c38f:: with SMTP id s15mr12647599wmj.16.1624032598138; Fri, 18 Jun 2021 09:09:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLUaWfYarKclk/pk0whorWc+vh50XluWHjeyONXXmrB3hIuUhUqG7oF0RAGfavqejmIMJJ/w== X-Received: by 2002:a7b:c38f:: with SMTP id s15mr12647557wmj.16.1624032597881; Fri, 18 Jun 2021 09:09:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id c21sm8040006wme.38.2021.06.18.09.09.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 09:09:57 -0700 (PDT) Subject: Re: [PATCH v3 02/24] modules: collect module meta-data To: Gerd Hoffmann , qemu-devel@nongnu.org References: <20210618045353.2510174-1-kraxel@redhat.com> <20210618045353.2510174-3-kraxel@redhat.com> From: Paolo Bonzini Message-ID: <919b1ff3-914b-a9a2-781f-d8ae244d71cf@redhat.com> Date: Fri, 18 Jun 2021 18:09:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210618045353.2510174-3-kraxel@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.194, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.202, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, David Hildenbrand , Richard Henderson , Cornelia Huck , Peter Lieven , Max Reitz , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , Ronnie Sahlberg , Cleber Rosa , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Samuel Thibault Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/06/21 06:53, Gerd Hoffmann wrote: > +def find_command(src, target, compile_commands): > + for command in compile_commands: > + if command['file'] != src: > + continue > + if target != '' and command['command'].find(target) == -1: > + continue Did you look into using extract_objects for this instead of looking for the target (which works, but yuck :))? Paolo