From: Hyman Huang <yong.huang@smartx.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
Eric Blake <eblake@redhat.com>,
yong.huang@smartx.com
Subject: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment
Date: Wed, 21 Feb 2024 11:36:58 +0800 [thread overview]
Message-ID: <91c52e03e46ff0a96559b4e7d66ded582b2ec4e1.1708486450.git.yong.huang@smartx.com> (raw)
Add comment in detail for commit 433957bb7f (qapi:
Make parameter 'file' optional for
BlockdevCreateOptionsLUKS).
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
---
qapi/block-core.json | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ab5a93a966..42b0840d43 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -4973,7 +4973,25 @@
##
# @BlockdevCreateOptionsLUKS:
#
-# Driver specific image creation options for LUKS.
+# Driver specific image creation options for LUKS. Note that
+# @file is required if @preallocation is specified and equals
+# PREALLOC_MODE_ON. The following three scenarios determine how
+# creation logic behaves when @preallocation is either equal to
+# PREALLOC_MODE_OFF or is not given:
+#
+# 1) When @file is given only, format the block device referenced
+# by @file as the LUKS specification and trunk it to the @size.
+# In this case, the @size should reflect amount of space made
+# available to the guest, so the trunk size must take account
+# of that which will be used by the crypto header.
+#
+# 2) When @header is given only, just format the block device
+# referenced by @header as the LUKS specification.
+#
+# 3) When both @file and @header are given, block device
+# referenced by @file should be trunked to @size, and block
+# device referenced by @header should be formatted as the LUKS
+# specification.
#
# @file: Node to create the image format on, mandatory except when
# 'preallocation' is not requested
--
2.39.3
next reply other threads:[~2024-02-21 3:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 3:36 Hyman Huang [this message]
2024-02-21 6:43 ` [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment Markus Armbruster
2024-02-21 7:08 ` Yong Huang
2024-02-21 8:26 ` Markus Armbruster
2024-02-21 8:49 ` Yong Huang
2024-02-28 6:43 ` Markus Armbruster
2024-02-28 10:17 ` Kevin Wolf
2024-02-28 10:23 ` Daniel P. Berrangé
2024-02-28 11:21 ` Kevin Wolf
2024-02-28 11:26 ` Daniel P. Berrangé
2024-02-28 11:30 ` Daniel P. Berrangé
2024-02-28 11:58 ` Kevin Wolf
2024-02-29 2:04 ` Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91c52e03e46ff0a96559b4e7d66ded582b2ec4e1.1708486450.git.yong.huang@smartx.com \
--to=yong.huang@smartx.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).