From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goOfo-0004rR-8k for qemu-devel@nongnu.org; Tue, 29 Jan 2019 03:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goOfn-0002yp-GP for qemu-devel@nongnu.org; Tue, 29 Jan 2019 03:23:12 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goOfn-0002yM-8p for qemu-devel@nongnu.org; Tue, 29 Jan 2019 03:23:11 -0500 Received: by mail-wr1-f67.google.com with SMTP id l9so20898465wrt.13 for ; Tue, 29 Jan 2019 00:23:11 -0800 (PST) References: <20190125060157.29935-1-richardw.yang@linux.intel.com> <20190129000820.31190-1-richardw.yang@linux.intel.com> <20190129080455.GA10084@richard> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <91c53c72-8e9c-f68d-1dc8-f6320ed3dfc0@redhat.com> Date: Tue, 29 Jan 2019 09:23:08 +0100 MIME-Version: 1.0 In-Reply-To: <20190129080455.GA10084@richard> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, imammedo@redhat.com, laurent@vivier.eu, mst@redhat.com On 1/29/19 9:04 AM, Wei Yang wrote: > On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Wei, >> >> On 1/29/19 1:08 AM, Wei Yang wrote: >>> There are several functions/variable which are not used anymore. >>> >>> This serials just remove those without functional change. >>> >>> Wei Yang (3): >>> hw/i386/pc.c: remove unused function pc_acpi_init() >>> hw/acpi: remove unused function acpi_table_add_builtin() >>> hw/acpi: remove unnecessary variable acpi_table_builtin >>> >>> hw/acpi/core.c | 10 +--------- >>> hw/i386/pc.c | 27 --------------------------- >>> include/hw/acpi/acpi.h | 1 - >>> include/hw/i386/pc.h | 1 - >>> 4 files changed, 1 insertion(+), 38 deletions(-) >>> >> >> Please do not post iterated series in reply to previous version, but as >> new thread: >> - patches are parsed by scripts >> - some email clients can tag a thread as "reviewed, skip" and replies to >> this thread will be masked. >> > > Well, do I need to repost it in a new thread? It depends who will take this patchset and his mood :) Let's wait and see.