[PATCH] ds1225y: Fix nvram MemoryRegion owner

[PATCH] ds1225y: Fix nvram MemoryRegion owner

[Akihiko Odaki]

s points to the MemoryRegion itself. dev points to DS1225Y, the real
owner.

Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
---
 hw/nvram/ds1225y.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c
index dbfd0d2e5369..0945e36652e9 100644
--- a/hw/nvram/ds1225y.c
+++ b/hw/nvram/ds1225y.c
@@ -126,7 +126,7 @@ static void nvram_sysbus_realize(DeviceState *dev, Error **errp)
 
     s->contents = g_malloc0(s->chip_size);
 
-    memory_region_init_io(&s->iomem, OBJECT(s), &nvram_ops, s,
+    memory_region_init_io(&s->iomem, OBJECT(dev), &nvram_ops, s,
                           "nvram", s->chip_size);
     sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem);
 

---
base-commit: c85ba2d7a4056595166689890285105579db446a
change-id: 20251027-ds1225y-0cbe83430a78

Best regards,
--  
Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>

Re: [PATCH] ds1225y: Fix nvram MemoryRegion owner

[Philippe Mathieu-Daudé]

On 27/10/25 02:05, Akihiko Odaki wrote:
> s points to the MemoryRegion itself. dev points to DS1225Y, the real
> owner.
> 
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
>   hw/nvram/ds1225y.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

and queued, thanks!

Re: [PATCH] ds1225y: Fix nvram MemoryRegion owner

[Philippe Mathieu-Daudé]

On 27/10/25 02:05, Akihiko Odaki wrote:
> s points to the MemoryRegion itself. dev points to DS1225Y, the real
> owner.
> 
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
>   hw/nvram/ds1225y.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Queued, thanks!

Re: [PATCH] ds1225y: Fix nvram MemoryRegion owner

[Michael Tokarev]

On 10/27/25 04:05, Akihiko Odaki wrote:
> s points to the MemoryRegion itself. dev points to DS1225Y, the real
> owner.
> 
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
>   hw/nvram/ds1225y.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c
> index dbfd0d2e5369..0945e36652e9 100644
> --- a/hw/nvram/ds1225y.c
> +++ b/hw/nvram/ds1225y.c
> @@ -126,7 +126,7 @@ static void nvram_sysbus_realize(DeviceState *dev, Error **errp)
>   
>       s->contents = g_malloc0(s->chip_size);
>   
> -    memory_region_init_io(&s->iomem, OBJECT(s), &nvram_ops, s,
> +    memory_region_init_io(&s->iomem, OBJECT(dev), &nvram_ops, s,
>                             "nvram", s->chip_size);
>       sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem);

What's the impact of this issue?
Should it go to the stable series perhaps?

Thanks,

/mjt

Re: [PATCH] ds1225y: Fix nvram MemoryRegion owner

[Akihiko Odaki]

On 2025/10/28 21:28, Michael Tokarev wrote:
> On 10/27/25 04:05, Akihiko Odaki wrote:
>> s points to the MemoryRegion itself. dev points to DS1225Y, the real
>> owner.
>>
>> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
>> ---
>>   hw/nvram/ds1225y.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c
>> index dbfd0d2e5369..0945e36652e9 100644
>> --- a/hw/nvram/ds1225y.c
>> +++ b/hw/nvram/ds1225y.c
>> @@ -126,7 +126,7 @@ static void nvram_sysbus_realize(DeviceState *dev, 
>> Error **errp)
>>       s->contents = g_malloc0(s->chip_size);
>> -    memory_region_init_io(&s->iomem, OBJECT(s), &nvram_ops, s,
>> +    memory_region_init_io(&s->iomem, OBJECT(dev), &nvram_ops, s,
>>                             "nvram", s->chip_size);
>>       sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem);
> 
> What's the impact of this issue?
> Should it go to the stable series perhaps?

There should be no perceivable impact. It causes memory leak if the 
device is hotpluggable, but it is apparently not the case.

The same goes for "[PATCH] hw/riscv/riscv-iommu: Fix MemoryRegion owner":
https://lore.kernel.org/qemu-devel/20251027-iommu-v1-1-0fc52a02a273@rsg.ci.i.u-tokyo.ac.jp/

Regards,
Akihiko Odaki