From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhao Liu <zhao1.liu@linux.intel.com>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Yanan Wang <wangyanan55@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Babu Moger <babu.moger@amd.com>, Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH v2 02/17] tests: Rename test-x86-cpuid.c to test-x86-topo.c
Date: Wed, 28 Jun 2023 08:21:33 +0200 [thread overview]
Message-ID: <91de0bfc-9150-ae82-1067-83946eb963e8@linaro.org> (raw)
In-Reply-To: <20230529123101.411267-3-zhao1.liu@linux.intel.com>
On 29/5/23 14:30, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> In fact, this unit tests APIC ID other than CPUID.
> Rename to test-x86-topo.c to make its name more in line with its
> actual content.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Changes since v1:
> * Rename test-x86-apicid.c to test-x86-topo.c. (Yanan)
> ---
> MAINTAINERS | 2 +-
> tests/unit/meson.build | 4 ++--
> tests/unit/{test-x86-cpuid.c => test-x86-topo.c} | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
> rename tests/unit/{test-x86-cpuid.c => test-x86-topo.c} (99%)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-28 6:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 12:30 [PATCH v2 00/17] Support smp.clusters for x86 Zhao Liu
2023-05-29 12:30 ` [PATCH v2 01/17] i386: Fix comment style in topology.h Zhao Liu
2023-05-29 12:30 ` [PATCH v2 02/17] tests: Rename test-x86-cpuid.c to test-x86-topo.c Zhao Liu
2023-06-28 6:21 ` Philippe Mathieu-Daudé [this message]
2023-05-29 12:30 ` [PATCH v2 03/17] softmmu: Fix CPUSTATE.nr_cores' calculation Zhao Liu
2023-05-29 12:30 ` [PATCH v2 04/17] i386/cpu: Fix i/d-cache topology to core level for Intel CPU Zhao Liu
2023-05-29 12:30 ` [PATCH v2 05/17] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4] Zhao Liu
2023-05-29 12:30 ` [PATCH v2 06/17] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid() Zhao Liu
2023-05-29 12:30 ` [PATCH v2 07/17] i386: Introduce module-level cpu topology to CPUX86State Zhao Liu
2023-05-29 12:30 ` [PATCH v2 08/17] i386: Support modules_per_die in X86CPUTopoInfo Zhao Liu
2023-05-29 12:30 ` [PATCH v2 09/17] i386: Support module_id in X86CPUTopoIDs Zhao Liu
2023-05-29 12:30 ` [PATCH v2 10/17] i386/cpu: Introduce cluster-id to X86CPU Zhao Liu
2023-05-29 12:30 ` [PATCH v2 11/17] tests: Add test case of APIC ID for module level parsing Zhao Liu
2023-05-29 12:30 ` [PATCH v2 12/17] hw/i386/pc: Support smp.clusters for x86 PC machine Zhao Liu
2023-05-29 12:30 ` [PATCH v2 13/17] i386: Add cache topology info in CPUCacheInfo Zhao Liu
2023-05-29 12:30 ` [PATCH v2 14/17] i386: Use CPUCacheInfo.share_level to encode CPUID[4] Zhao Liu
2023-05-29 12:30 ` [PATCH v2 15/17] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14] Zhao Liu
2023-05-29 12:31 ` [PATCH v2 16/17] i386: Use CPUCacheInfo.share_level to encode " Zhao Liu
2023-05-29 12:31 ` [PATCH v2 17/17] i386: Add new property to control L2 cache topo in CPUID.04H Zhao Liu
2023-06-13 7:57 ` [PATCH v2 00/17] Support smp.clusters for x86 Zhao Liu
2023-06-14 1:59 ` Ma, Yongwei
2023-06-22 20:14 ` Michael S. Tsirkin
2023-06-28 1:18 ` Zhao Liu
2023-07-10 18:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91de0bfc-9150-ae82-1067-83946eb963e8@linaro.org \
--to=philmd@linaro.org \
--cc=babu.moger@amd.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).