io_uring code appears to be broken

io_uring code appears to be broken

[Rebecca Cran]

I noticed that after installing liburing-devel-0.2-lp152.2.1.x86_64, a 
"./configure" causes support for io_uring to be enabled by default.

It appears to be broken, so I was wondering if it should be disabled 
unless explicitly enabled via configure?

I'm running openSUSE Leap 15.2.

[285/9281] Compiling C object libqemuutil.a.p/util_fdmon-io_uring.c.o
FAILED: libqemuutil.a.p/util_fdmon-io_uring.c.o
cc -Ilibqemuutil.a.p -I. -I.. -Isubprojects/libvhost-user 
-I../subprojects/libvhost-user -Iqapi -Itrace -Iui -Iui/shader 
-I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 
-I/usr/lib64/glib-2.0/include -I/usr/include/libmount 
-I/usr/include/blkid -I/usr/include/uuid -I/usr/include/gio-unix-2.0 
-fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 
-O2 -g -isystem /home/jenkins/qemu/linux-headers -isystem linux-headers 
-iquote . -iquote /home/jenkins/qemu -iquote /home/jenkins/qemu/include 
-iquote /home/jenkins/qemu/disas/libvixl -iquote 
/home/jenkins/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE 
-D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common 
-fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits 
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
-Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined 
-Wimplicit-fallthrough=2 -Wno-missing-include-dirs 
-Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIC -MD 
-MQ libqemuutil.a.p/util_fdmon-io_uring.c.o -MF 
libqemuutil.a.p/util_fdmon-io_uring.c.o.d -o 
libqemuutil.a.p/util_fdmon-io_uring.c.o -c ../util/fdmon-io_uring.c
../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’:
../util/fdmon-io_uring.c:305:9: error: implicit declaration of function 
‘io_uring_sq_ready’; did you mean ‘io_uring_cq_ready’? 
[-Werror=implicit-function-declaration]
      if (io_uring_sq_ready(&ctx->fdmon_io_uring)) {
          ^~~~~~~~~~~~~~~~~
          io_uring_cq_ready
../util/fdmon-io_uring.c:305:9: error: nested extern declaration of 
‘io_uring_sq_ready’ [-Werror=nested-externs]


-- 
Rebecca Cran

Re: io_uring code appears to be broken

[Rebecca Cran]

Of course I realized I only have headers for version 0.2 and upstream is 
now up to 2.0, so it looks like I just need to update.

-- 
Rebecca Cran

On 5/8/21 3:19 PM, Rebecca Cran wrote:
> I noticed that after installing liburing-devel-0.2-lp152.2.1.x86_64, a 
> "./configure" causes support for io_uring to be enabled by default.
> 
> It appears to be broken, so I was wondering if it should be disabled 
> unless explicitly enabled via configure?
> 
> I'm running openSUSE Leap 15.2.
> 
> [285/9281] Compiling C object libqemuutil.a.p/util_fdmon-io_uring.c.o
> FAILED: libqemuutil.a.p/util_fdmon-io_uring.c.o
> cc -Ilibqemuutil.a.p -I. -I.. -Isubprojects/libvhost-user 
> -I../subprojects/libvhost-user -Iqapi -Itrace -Iui -Iui/shader 
> -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 
> -I/usr/lib64/glib-2.0/include -I/usr/include/libmount 
> -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/gio-unix-2.0 
> -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 
> -O2 -g -isystem /home/jenkins/qemu/linux-headers -isystem linux-headers 
> -iquote . -iquote /home/jenkins/qemu -iquote /home/jenkins/qemu/include 
> -iquote /home/jenkins/qemu/disas/libvixl -iquote 
> /home/jenkins/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE 
> -D_FORTIFY_SOURCE=2 -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
> -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common 
> -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
> -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined 
> -Wimplicit-fallthrough=2 -Wno-missing-include-dirs 
> -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIC -MD 
> -MQ libqemuutil.a.p/util_fdmon-io_uring.c.o -MF 
> libqemuutil.a.p/util_fdmon-io_uring.c.o.d -o 
> libqemuutil.a.p/util_fdmon-io_uring.c.o -c ../util/fdmon-io_uring.c
> ../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’:
> ../util/fdmon-io_uring.c:305:9: error: implicit declaration of function 
> ‘io_uring_sq_ready’; did you mean ‘io_uring_cq_ready’? 
> [-Werror=implicit-function-declaration]
>      if (io_uring_sq_ready(&ctx->fdmon_io_uring)) {
>          ^~~~~~~~~~~~~~~~~
>          io_uring_cq_ready
> ../util/fdmon-io_uring.c:305:9: error: nested extern declaration of 
> ‘io_uring_sq_ready’ [-Werror=nested-externs]
> 
>