qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Filip Bozuta <Filip.Bozuta@syrmia.com>
Subject: Re: [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative
Date: Wed, 8 Jul 2020 08:52:44 -0700	[thread overview]
Message-ID: <91f28ac2-c3be-7088-db8a-6bad60fc2c1f@linaro.org> (raw)
In-Reply-To: <20200708152435.706070-3-laurent@vivier.eu>

On 7/8/20 8:24 AM, Laurent Vivier wrote:
> -static void
> +static bool
>  print_syscall_err(abi_long ret)
>  {
> -    const char *errstr = NULL;
> +    const char *errstr;
>  
>      qemu_log(" = ");
>      if (ret < 0) {

This should be a target-specific test.

E.g. on most asm-generic I'm pretty sure this should be

    if ((abi_ulong)ret > -(abi_ulong)512)

whereas for Alpha it should be

    /*
     * Syscall writes 0 to V0 to bypass error check, similar
     * to how this is handled internal to Linux kernel.
     */
    if (ret < 0 && env->ir[IR_V0] != 0)


r~


  reply	other threads:[~2020-07-08 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 15:24 [PATCH v2 0/2] linux-user: fix print_syscall_err() Laurent Vivier
2020-07-08 15:24 ` [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err() Laurent Vivier
2020-07-08 15:49   ` Richard Henderson
2020-07-08 16:47   ` Philippe Mathieu-Daudé
2020-07-10 13:48   ` Filip Bozuta
2020-07-13 19:29   ` Laurent Vivier
2020-07-08 15:24 ` [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative Laurent Vivier
2020-07-08 15:52   ` Richard Henderson [this message]
2020-07-08 16:13     ` Laurent Vivier
2020-07-13 19:34   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91f28ac2-c3be-7088-db8a-6bad60fc2c1f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Filip.Bozuta@syrmia.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).