* [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
@ 2019-08-28 12:33 Thomas Huth
2019-08-28 13:27 ` Christian Borntraeger
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-08-28 12:33 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel; +Cc: qemu-s390x, Cornelia Huck
We're clearing the BSS in start.S now, so there is no need to
pre-initialize the loadparm_str array with zeroes anymore.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index a69c73349e..a21b386280 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -17,7 +17,7 @@
char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE)));
static SubChannelId blk_schid = { .one = 1 };
-static char loadparm_str[LOADPARM_LEN + 1] = { 0, 0, 0, 0, 0, 0, 0, 0, 0 };
+static char loadparm_str[LOADPARM_LEN + 1];
QemuIplParameters qipl;
IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));
static bool have_iplb;
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
2019-08-28 12:33 [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array Thomas Huth
@ 2019-08-28 13:27 ` Christian Borntraeger
2019-08-28 13:42 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2019-08-28 13:27 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-s390x, Cornelia Huck
On 28.08.19 14:33, Thomas Huth wrote:
> We're clearing the BSS in start.S now, so there is no need to
> pre-initialize the loadparm_str array with zeroes anymore.
Can you add a link to the commit that does the bss clearing?
I think it was
commit 339686a358b11a231aa5b6d1424e7a1460d7f277
Author: Christian Borntraeger <borntraeger@de.ibm.com>
AuthorDate: Wed Nov 22 15:26:27 2017 +0100
Commit: Cornelia Huck <cohuck@redhat.com>
CommitDate: Thu Dec 14 17:56:54 2017 +0100
pc-bios/s390-ccw: zero out bss section
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
> index a69c73349e..a21b386280 100644
> --- a/pc-bios/s390-ccw/main.c
> +++ b/pc-bios/s390-ccw/main.c
> @@ -17,7 +17,7 @@
>
> char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE)));
> static SubChannelId blk_schid = { .one = 1 };
> -static char loadparm_str[LOADPARM_LEN + 1] = { 0, 0, 0, 0, 0, 0, 0, 0, 0 };
> +static char loadparm_str[LOADPARM_LEN + 1];
> QemuIplParameters qipl;
> IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));
> static bool have_iplb;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
2019-08-28 13:27 ` Christian Borntraeger
@ 2019-08-28 13:42 ` Thomas Huth
2019-08-28 13:47 ` Cornelia Huck
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-08-28 13:42 UTC (permalink / raw)
To: Christian Borntraeger, qemu-devel; +Cc: qemu-s390x, Cornelia Huck
On 28/08/2019 15.27, Christian Borntraeger wrote:
> On 28.08.19 14:33, Thomas Huth wrote:
>> We're clearing the BSS in start.S now, so there is no need to
>> pre-initialize the loadparm_str array with zeroes anymore.
>
> Can you add a link to the commit that does the bss clearing?
Sure, I'll change the description to:
"
Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
zero out bss section"), we are clearing now the BSS in start.S, so there
is no need to pre-initialize the loadparm_str array with zeroes anymore.
"
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
2019-08-28 13:42 ` Thomas Huth
@ 2019-08-28 13:47 ` Cornelia Huck
2019-08-28 13:48 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
0 siblings, 1 reply; 6+ messages in thread
From: Cornelia Huck @ 2019-08-28 13:47 UTC (permalink / raw)
To: Thomas Huth; +Cc: Christian Borntraeger, qemu-s390x, qemu-devel
On Wed, 28 Aug 2019 15:42:37 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 28/08/2019 15.27, Christian Borntraeger wrote:
> > On 28.08.19 14:33, Thomas Huth wrote:
> >> We're clearing the BSS in start.S now, so there is no need to
> >> pre-initialize the loadparm_str array with zeroes anymore.
> >
> > Can you add a link to the commit that does the bss clearing?
>
> Sure, I'll change the description to:
>
> "
> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
> zero out bss section"), we are clearing now the BSS in start.S, so there
> is no need to pre-initialize the loadparm_str array with zeroes anymore.
> "
>
> Thomas
With that:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
2019-08-28 13:47 ` Cornelia Huck
@ 2019-08-28 13:48 ` Christian Borntraeger
2019-08-28 13:52 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2019-08-28 13:48 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth; +Cc: qemu-s390x, qemu-devel
On 28.08.19 15:47, Cornelia Huck wrote:
> On Wed, 28 Aug 2019 15:42:37 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 28/08/2019 15.27, Christian Borntraeger wrote:
>>> On 28.08.19 14:33, Thomas Huth wrote:
>>>> We're clearing the BSS in start.S now, so there is no need to
>>>> pre-initialize the loadparm_str array with zeroes anymore.
>>>
>>> Can you add a link to the commit that does the bss clearing?
>>
>> Sure, I'll change the description to:
>>
>> "
>> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
>> zero out bss section"), we are clearing now the BSS in start.S, so there
>> is no need to pre-initialize the loadparm_str array with zeroes anymore.
>> "
>>
>> Thomas
>
> With that:
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Thomas are you going to pick this up or shall I do it?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array
2019-08-28 13:48 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
@ 2019-08-28 13:52 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2019-08-28 13:52 UTC (permalink / raw)
To: Christian Borntraeger, Cornelia Huck; +Cc: qemu-s390x, qemu-devel
On 28/08/2019 15.48, Christian Borntraeger wrote:
>
>
> On 28.08.19 15:47, Cornelia Huck wrote:
>> On Wed, 28 Aug 2019 15:42:37 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> On 28/08/2019 15.27, Christian Borntraeger wrote:
>>>> On 28.08.19 14:33, Thomas Huth wrote:
>>>>> We're clearing the BSS in start.S now, so there is no need to
>>>>> pre-initialize the loadparm_str array with zeroes anymore.
>>>>
>>>> Can you add a link to the commit that does the bss clearing?
>>>
>>> Sure, I'll change the description to:
>>>
>>> "
>>> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw:
>>> zero out bss section"), we are clearing now the BSS in start.S, so there
>>> is no need to pre-initialize the loadparm_str array with zeroes anymore.
>>> "
>
>>>
>>> Thomas
>>
>> With that:
>>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Thomas are you going to pick this up or shall I do it?
I don't mind either way. Not sure whether this patch justifies a bios
rebuild, so I'd rather wait for some more time for other bios patches to
show up. But if you want to pick it up (together with the "fix a
possible memory leak in get_uuid" patch that is still pending), please
go ahead.
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-28 13:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-28 12:33 [Qemu-devel] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array Thomas Huth
2019-08-28 13:27 ` Christian Borntraeger
2019-08-28 13:42 ` Thomas Huth
2019-08-28 13:47 ` Cornelia Huck
2019-08-28 13:48 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-08-28 13:52 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).