From: Jason Wang <jasowang@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v5 04/21] net: Remove receive_raw()
Date: Mon, 30 Oct 2023 11:06:56 +0800 [thread overview]
Message-ID: <9204e711-0eb9-01da-54dd-c67ae9e05c3b@redhat.com> (raw)
In-Reply-To: <ef82309f-ca89-4850-acf6-94ffa7726c2f@daynix.com>
在 2023/10/27 15:52, Akihiko Odaki 写道:
> On 2023/10/27 15:49, Jason Wang wrote:
>> On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki
>> <akihiko.odaki@daynix.com> wrote:
>>>
>>> While netmap implements virtio-net header, it does not implement
>>> receive_raw().
>>
>> The only user for raw is the announcing. Netmap probably doesn't it
>> at all.
>
> In my understanding, the announcing *sends* a raw packet.
It's send via NIC and receive by its peer which is the TAP
qemu_send_packet_raw() -> nc -> nc->peer -> peer->receive_raw()?
Anything I miss?
Thanks
> Both of tap and netmap *receive* packets with virtio-net headers.
>
> Regards,
> Akihiko Odaki
>
next prev parent reply other threads:[~2023-10-30 3:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 4:09 [PATCH v5 00/21] virtio-net RSS/hash report fixes and improvements Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 01/21] tap: Remove tap_probe_vnet_hdr_len() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 02/21] tap: Remove qemu_using_vnet_hdr() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 03/21] net: Move virtio-net header length assertion Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 04/21] net: Remove receive_raw() Akihiko Odaki
2023-10-27 6:49 ` Jason Wang
2023-10-27 7:52 ` Akihiko Odaki
2023-10-30 3:06 ` Jason Wang [this message]
2023-10-30 4:03 ` Akihiko Odaki
2023-10-30 4:08 ` Jason Wang
2023-10-30 4:16 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 05/21] tap: Remove tap_receive() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 06/21] net: Remove flag propagation Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 07/21] tap: Shrink zeroed virtio-net header Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 08/21] virtio-net: Copy header only when necessary Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 09/21] virtio-net: Disable RSS on reset Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 10/21] virtio-net: Unify the logic to update NIC state for RSS Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 11/21] virtio-net: Return an error when vhost cannot enable RSS Akihiko Odaki
2023-10-27 7:07 ` Jason Wang
2023-10-27 7:54 ` Akihiko Odaki
2023-10-30 3:44 ` Jason Wang
2023-10-29 22:15 ` Yuri Benditovich
2023-10-17 4:09 ` [PATCH v5 12/21] virtio-net: Always set populate_hash Akihiko Odaki
2023-10-27 7:08 ` Jason Wang
2023-10-27 7:57 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 13/21] virtio-net: Do not clear VIRTIO_NET_F_RSS Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 14/21] virtio-net: Do not write hashes to peer buffer Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT Akihiko Odaki
2023-10-27 7:14 ` Jason Wang
2023-10-27 8:07 ` Akihiko Odaki
2023-10-29 21:56 ` Yuri Benditovich
2023-10-30 3:59 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 16/21] ebpf: Fix RSS error handling Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 17/21] ebpf: Use standard section name Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 18/21] ebpf: Simplify error handling Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 19/21] ebpf: Return 0 when configuration fails Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 20/21] ebpf: Refactor tun_rss_steering_prog() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 21/21] ebpf: Add a separate target for skeleton Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9204e711-0eb9-01da-54dd-c67ae9e05c3b@redhat.com \
--to=jasowang@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).