From: Thomas Huth <thuth@redhat.com>
To: Nikita Ivanov <nivanov@cloudlinux.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 0/2] Refactoring: expand usage of TFR() macro
Date: Wed, 4 Jan 2023 10:47:53 +0100 [thread overview]
Message-ID: <92131031-46de-e37d-31d4-f12cc6edcc9c@redhat.com> (raw)
In-Reply-To: <CAAJ4Ao-aa+Gnf_=8THxC4_6cayJJ8QM50bH1MXuM5t+x3CPLYg@mail.gmail.com>
On 02/11/2022 21.30, Nikita Ivanov wrote:
> Hi!
> Is there any update on this? I haven't received any comments.
Sorry, seems like this fell through the cracks since it was not quite clear
which maintainer should pick it up. I'll take the patches for my next pull
request.
Thomas
> On Sun, Oct 23, 2022 at 12:04 PM Nikita Ivanov <nivanov@cloudlinux.com
> <mailto:nivanov@cloudlinux.com>> wrote:
>
> At the moment, TFR() macro has a vague name and is not used
> where it possibly could be. In order to make it more transparent
> and useful, it was decided to refactor it to make it closer to
> the similar one in glibc: TEMP_FAILURE_RETRY(). Now, macro
> evaluates into an expression and is named RETRY_ON_EINTR(). All the
> places where RETRY_ON_EINTR() macro code be applied were covered.
>
> Nikita Ivanov (2):
> Refactoring: refactor TFR() macro to RETRY_ON_EINTR()
> error handling: Use RETRY_ON_EINTR() macro where applicable
>
> block/file-posix.c | 37 ++++++++++++++++---------------------
> chardev/char-fd.c | 2 +-
> chardev/char-pipe.c | 8 +++++---
> chardev/char-pty.c | 4 +---
> hw/9pfs/9p-local.c | 8 ++------
> include/qemu/osdep.h | 8 +++++++-
> net/l2tpv3.c | 17 +++++------------
> net/socket.c | 16 +++++++---------
> net/tap-bsd.c | 6 +++---
> net/tap-linux.c | 2 +-
> net/tap-solaris.c | 8 ++++----
> net/tap.c | 10 +++-------
> os-posix.c | 2 +-
> qga/commands-posix.c | 4 +---
> semihosting/syscalls.c | 4 +---
> tests/qtest/libqtest.c | 14 ++++++--------
> tests/vhost-user-bridge.c | 4 +---
> util/main-loop.c | 4 +---
> util/osdep.c | 4 +---
> util/vfio-helpers.c | 12 ++++++------
> 20 files changed, 73 insertions(+), 101 deletions(-)
>
> --
> 2.37.3
>
>
>
> --
> Best Regards,
> *Nikita Ivanov* | C developer
> *Telephone:* +79140870696
> *Telephone:* +79015053149
prev parent reply other threads:[~2023-01-04 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 9:04 [PATCH v4 0/2] Refactoring: expand usage of TFR() macro Nikita Ivanov
2022-10-23 9:04 ` [PATCH v4 1/2] Refactoring: refactor TFR() macro to RETRY_ON_EINTR() Nikita Ivanov
2022-10-23 9:04 ` [PATCH v4 2/2] error handling: Use RETRY_ON_EINTR() macro where applicable Nikita Ivanov
2022-11-02 20:30 ` [PATCH v4 0/2] Refactoring: expand usage of TFR() macro Nikita Ivanov
2023-01-04 9:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92131031-46de-e37d-31d4-f12cc6edcc9c@redhat.com \
--to=thuth@redhat.com \
--cc=nivanov@cloudlinux.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).