From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>,
qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH] hw/audio: Remove dead code from ac97_realize
Date: Tue, 4 Nov 2025 18:19:57 +0100 [thread overview]
Message-ID: <92164cea-f80f-4235-9946-1ca0621919e7@linaro.org> (raw)
In-Reply-To: <20251102231903.65409-1-osama.abdelkader@gmail.com>
On 3/11/25 00:19, Osama Abdelkader wrote:
> Remove unnecessary PCI configuration register initialization that was
> marked with TODO comments indicating it's redundant:
> - PCI_COMMAND register is already 0x00 by default, no need to override
> - PCI_BASE_ADDRESS_0 registers are automatically set by pci_register_bar()
>
> This aligns the code with the pattern used by other PCI audio devices
> in QEMU (via-ac97, intel-hda, es1370) and removes 15 lines of dead code.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> hw/audio/ac97.c | 19 -------------------
> 1 file changed, 19 deletions(-)
Queued, thanks!
prev parent reply other threads:[~2025-11-04 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 23:19 [PATCH] hw/audio: Remove dead code from ac97_realize Osama Abdelkader
2025-11-03 6:07 ` Marc-André Lureau
2025-11-04 17:19 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92164cea-f80f-4235-9946-1ca0621919e7@linaro.org \
--to=philmd@linaro.org \
--cc=kraxel@redhat.com \
--cc=osama.abdelkader@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).