From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] iotests: Fix cleanup path in some tests
Date: Mon, 24 Feb 2020 12:25:56 -0600 [thread overview]
Message-ID: <9224d842-faa6-678f-6a12-d76655db2743@redhat.com> (raw)
In-Reply-To: <20200224171631.384314-1-mreitz@redhat.com>
On 2/24/20 11:16 AM, Max Reitz wrote:
> Some iotests leave behind some external data file when run for qcow2
> with -o data_file. Fix that.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/085 | 1 +
> tests/qemu-iotests/087 | 6 ++++++
> tests/qemu-iotests/279 | 2 +-
> 3 files changed, 8 insertions(+), 1 deletion(-)
>
I'd LOVE for someone to take on a GSOC project to finish the work Jeff
Cody once proposed on having iotests run each test in its own dedicated
directory, such that files are left behind on failure for easy
investigation, and cleanup is a snap of just deleting that directory on
success.
But until then, adding manual cleanup where we missed it is correct.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-02-24 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:16 [PATCH] iotests: Fix cleanup path in some tests Max Reitz
2020-02-24 17:47 ` no-reply
2020-02-24 18:25 ` Eric Blake [this message]
2020-03-24 10:58 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9224d842-faa6-678f-6a12-d76655db2743@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).