Re: [PATCH v2 00/11] ppc/spapr: remove deprecated machines specific code

[Harsh Prateek Bora <harshpb@linux.ibm.com>]

Hi Cedric,

On 10/2/24 12:26, Cédric Le Goater wrote:
> Hello Harsh,
> 
> On 10/1/24 11:28, Harsh Prateek Bora wrote:
>> Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
>> deprecated with reasons mentioned in its commit log.
>> Removing the arch specific code for the now deprecated machine types.
>>
>> v2: Addressed review comments from Cedric
>> v1: <20240917060300.943496-1-harshpb@linux.ibm.com>
>> Harsh Prateek Bora (11):
>>    ppc/spapr: remove deprecated machine pseries-2.1
>>    ppc/spapr: remove deprecated machine pseries-2.2
>>    ppc/spapr: remove deprecated machine pseries-2.3
>>    ppc/spapr: remove deprecated machine pseries-2.4
>>    ppc/spapr: remove deprecated machine pseries-2.5
>>    ppc/spapr: remove deprecated machine pseries-2.6
>>    ppc/spapr: remove deprecated machine pseries-2.7
>>    ppc/spapr: remove deprecated machine pseries-2.8
>>    ppc/spapr: remove deprecated machine pseries-2.9
>>    ppc/spapr: remove deprecated machine pseries-2.10
>>    ppc/spapr: remove deprecated machine pseries-2.11
> 
> LGTM, I had a few questions.
> 

Thanks, I shall address the review comments in next iteration.

> Please be aware that the next QEMU cycle will have more machines
> to deprecate.
> 

I realized that 2.12 had also been marked as deprecated earlier which I
can include in v3, however would like to understand the rationale behind
choosing the remaining until pseries-6.1 for deprecating in next release
cycle. Please enlighten.

regards,
Harsh

> pseries-2.1          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.10         pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.11         pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.12         pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.12-sxxm    pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.2          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.3          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.4          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.5          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.6          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.7          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.8          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-2.9          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-3.0          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-3.1          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-4.0          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-4.1          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-4.2          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-5.0          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-5.1          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-5.2          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-6.0          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> pseries-6.1          pSeries Logical Partition (PAPR compliant) 
> (deprecated)
> 
> Thanks,
> 
> C.
>