From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Anton Johansson" <anjo@rev.ng>
Subject: Re: [PATCH 09/11] accel/tcg: Fix tlb_set_page_with_attrs, tlb_set_page
Date: Wed, 12 Feb 2025 10:21:33 -0800 [thread overview]
Message-ID: <9231fa0b-f7e8-4e53-9acf-7f89d81f6b60@linaro.org> (raw)
In-Reply-To: <9759c6f3-18c7-4693-a2db-8a10fea182c8@linaro.org>
On 2/11/25 23:22, Philippe Mathieu-Daudé wrote:
> On 5/2/25 05:03, Richard Henderson wrote:
>> The declarations use vaddr for size.
>
> Which seems dubious, since TARGET_PAGE_SIZE is int IIUC.
This parameter must handle guest huge pages. Most often this is 2MiB or 1GiB, which do
fit in "int", but logically could be any size at all. So vaddr seems the correct type.
r~
next prev parent reply other threads:[~2025-02-12 18:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 4:03 [PATCH 00/11] tcg: Cleanups after disallowing 64-on-32 Richard Henderson
2025-02-05 4:03 ` [PATCH 01/11] tcg: Drop support for two address registers in gen_ldst Richard Henderson
2025-02-13 14:37 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 02/11] tcg: Merge INDEX_op_qemu_*_{a32,a64}_* Richard Henderson
2025-02-17 14:22 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 03/11] tcg/arm: Drop addrhi from prepare_host_addr Richard Henderson
2025-02-17 12:12 ` Philippe Mathieu-Daudé
2025-02-17 16:44 ` Richard Henderson
2025-02-05 4:03 ` [PATCH 04/11] tcg/i386: " Richard Henderson
2025-02-13 14:35 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 05/11] tcg/mips: " Richard Henderson
2025-02-13 14:33 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 06/11] tcg/ppc: " Richard Henderson
2025-02-13 14:34 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 07/11] tcg: Replace addr{lo, hi}_reg with addr_reg in TCGLabelQemuLdst Richard Henderson
2025-02-12 7:14 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 08/11] plugins: Fix qemu_plugin_read_memory_vaddr parameters Richard Henderson
2025-02-12 7:16 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 09/11] accel/tcg: Fix tlb_set_page_with_attrs, tlb_set_page Richard Henderson
2025-02-12 7:22 ` Philippe Mathieu-Daudé
2025-02-12 18:21 ` Richard Henderson [this message]
2025-02-17 7:32 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 10/11] include/exec: Change vaddr to uintptr_t Richard Henderson
2025-02-12 7:24 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 11/11] include/exec: Use uintptr_t in CPUTLBEntry Richard Henderson
2025-02-13 14:29 ` Philippe Mathieu-Daudé
2025-02-15 20:06 ` [PATCH 00/11] tcg: Cleanups after disallowing 64-on-32 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9231fa0b-f7e8-4e53-9acf-7f89d81f6b60@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).