Re: [PATCH RESEND 0/2] rust/pl011: miscellaneous cleanups

[Paolo Bonzini <pbonzini@redhat.com>]

On 1/21/25 15:04, Zhao Liu wrote:
> (Resend the series since it was missed on https://lore.kernel.org/qemu-devel/.)
> 
> Hi,
> 
> This series includes the following cleanups:
> 
>   * Patch 1: Make realize() safe to only accept immutable self
>              reference, which is in prepare to introduce gpio bindings
>              [1].
> 
>   * Patch 2: Clean up `bindings::*` for pl011, which is inspired by
>              Paolo's comment on HPET [2].

Yep, me being lazy and not doing what I preach.

Queued---please forgive me for not posting again the series that are on 
the list, just with the "use bindings::foo" conflicts resolved. :)

Also, if you have to choose please review only the final 
qdev/MemoryRegion bits; the vmstate is mostly the same and the pl011 one 
has less impact on future code.

Paolo

> [1]: https://lore.kernel.org/qemu-devel/Z4h3Q%2FJBxtWxi+bK@intel.com/
> [2]: https://lore.kernel.org/qemu-devel/b107c5c3-9ee4-4939-a4e3-eff0cd92bad6@redhat.com/
> 
> Thanks and Best Regards,
> Zhao
> 
> ---
> Zhao Liu (2):
>    rust/qdev: Make REALIZE safe
>    rust/pl011: Avoid bindings::*
> 
>   rust/hw/char/pl011/src/device.rs | 23 +++++++++++++++--------
>   rust/qemu-api/src/qdev.rs        |  2 +-
>   2 files changed, 16 insertions(+), 9 deletions(-)
>