From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtcbj-0002Np-GH for qemu-devel@nongnu.org; Tue, 12 Feb 2019 13:16:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtcRU-0006Q8-Tq for qemu-devel@nongnu.org; Tue, 12 Feb 2019 13:06:05 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:36385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtcRT-0006MN-BD for qemu-devel@nongnu.org; Tue, 12 Feb 2019 13:06:00 -0500 Received: by mail-pg1-x543.google.com with SMTP id r124so1613613pgr.3 for ; Tue, 12 Feb 2019 10:05:55 -0800 (PST) References: <20190212110308.13707-1-david@redhat.com> <20190212110308.13707-5-david@redhat.com> From: Richard Henderson Message-ID: <925c8806-0a1a-c0d0-923c-167af4d548e4@linaro.org> Date: Tue, 12 Feb 2019 10:05:51 -0800 MIME-Version: 1.0 In-Reply-To: <20190212110308.13707-5-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 03/15] s390x/tcg: Factor out conversion of softfloat exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson On 2/12/19 3:02 AM, David Hildenbrand wrote: > We want to reuse that function in vector instruction context. While at it, > cleanup the code, using defines for magic values and avoiding the > handcrafted bit conversion. > > Signed-off-by: David Hildenbrand > --- > target/s390x/fpu_helper.c | 25 +++++++++++++------------ > target/s390x/internal.h | 7 +++++++ > 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~