From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time
Date: Wed, 3 Jul 2019 18:26:52 +0200 [thread overview]
Message-ID: <927219a5-a56d-bbbe-26ed-ffb8be12f006@linaro.org> (raw)
In-Reply-To: <20190703155244.28166-2-alex.bennee@linaro.org>
On 7/3/19 5:52 PM, Alex Bennée wrote:
> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
> +{
> + if (arm_dc_feature(s, ARM_FEATURE_M) &&
> + semihosting_enabled() &&
> +#ifndef CONFIG_USER_ONLY
> + s->current_el != 0 &&
> +#endif
> + (imm8 == 0xab)) {
Extra parenthesis. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-07-03 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 15:52 [Qemu-devel] [PATCH v1 0/4] arm semihosting cleanups Alex Bennée
2019-07-03 15:52 ` [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time Alex Bennée
2019-07-03 16:26 ` Richard Henderson [this message]
2019-07-04 10:21 ` Alex Bennée
2019-07-04 10:25 ` Philippe Mathieu-Daudé
2019-07-05 15:09 ` Richard Henderson
2019-07-03 15:52 ` [Qemu-devel] [PATCH v1 2/4] target/arm: handle A-profile T32 " Alex Bennée
2019-07-03 16:28 ` Richard Henderson
2019-07-03 15:52 ` [Qemu-devel] [PATCH v1 3/4] target/arm: handle A-profile A32 " Alex Bennée
2019-07-03 16:35 ` Richard Henderson
2019-07-03 15:52 ` [Qemu-devel] [PATCH v1 4/4] target/arm: remove run time semihosting checks Alex Bennée
2019-07-03 16:30 ` Philippe Mathieu-Daudé
2019-07-03 16:44 ` Alex Bennée
2019-07-03 16:53 ` Philippe Mathieu-Daudé
2019-07-03 16:38 ` Richard Henderson
2019-07-03 21:26 ` [Qemu-devel] [PATCH v1 0/4] arm semihosting cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927219a5-a56d-bbbe-26ed-ffb8be12f006@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).