From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Aurelien Jarno <aurelien@aurel32.net>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Magnus Damm <magnus.damm@gmail.com>,
qemu-ppc@nongnu.org, BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [PATCH 1/5] hw/ppc/sam460ex: Remove unreachable code calling pflash_cfi01_register()
Date: Mon, 9 Jan 2023 17:51:58 +0100 [thread overview]
Message-ID: <9274f53e-1cc8-7d49-95d4-a128fcc1f997@linaro.org> (raw)
In-Reply-To: <DD08389D-315E-4C44-BD39-020BC54B7337@gmail.com>
On 9/1/23 17:42, Bernhard Beschow wrote:
> Am 9. Januar 2023 12:01:50 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:
>> Since its QOM'ification in commit 368a354f02 ("pflash_cfi0x:
>> QOMified") the pflash_cfi01_register() function does not fail.
>>
>> This call was later converted with a script to use &error_fatal,
>> still unable to fail. Remove the unreachable code.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> hw/ppc/sam460ex.c | 12 ++++--------
>> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> It looks like there is more: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg02491.html
Doh, my short-term memory scares me :\
next prev parent reply other threads:[~2023-01-09 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 12:01 [PATCH 0/5] hw: Cleanups around PFLASH use Philippe Mathieu-Daudé
2023-01-09 12:01 ` [PATCH 1/5] hw/ppc/sam460ex: Remove unreachable code calling pflash_cfi01_register() Philippe Mathieu-Daudé
2023-01-09 12:38 ` BALATON Zoltan
2023-01-09 16:42 ` Bernhard Beschow
2023-01-09 16:51 ` Philippe Mathieu-Daudé [this message]
2023-01-09 12:01 ` [PATCH 2/5] hw/microblaze/petalogix: Add FLASH_SECTOR_SIZE definitions Philippe Mathieu-Daudé
2023-01-09 12:01 ` [PATCH 3/5] hw/mips/malta: Add the FLASH_SECTOR_SIZE definition Philippe Mathieu-Daudé
2023-01-09 12:01 ` [PATCH 4/5] hw/sh4/r2d: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2023-01-09 12:46 ` BALATON Zoltan
2023-01-09 13:12 ` Philippe Mathieu-Daudé
2023-01-09 14:02 ` BALATON Zoltan
2023-01-09 12:01 ` [PATCH 5/5] hw/sh4/r2d: Add the FLASH_SECTOR_SIZE definition Philippe Mathieu-Daudé
2023-01-09 12:49 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9274f53e-1cc8-7d49-95d4-a128fcc1f997@linaro.org \
--to=philmd@linaro.org \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=edgar.iglesias@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=magnus.damm@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shentey@gmail.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).