From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: fam@euphon.net, stefanha@redhat.com, jcody@redhat.com,
kwolf@redhat.com, den@openvz.org, eblake@redhat.com,
jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 10/11] block/backup: tiny refactor backup_job_create
Date: Fri, 18 Jan 2019 14:00:20 +0100 [thread overview]
Message-ID: <927a196d-fd7d-09bd-65f9-e5ef21c40629@redhat.com> (raw)
In-Reply-To: <20181229122027.42245-11-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote:
> Move copy-bitmap find/create code. It's needed for the following
> commit, as we'll need copy_bitmap before actual block job creation. Do
> it in a separate commit to simplify review.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/backup.c | 69 +++++++++++++++++++++++++++++---------------------
> 1 file changed, 40 insertions(+), 29 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-18 13:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:20 [Qemu-devel] [PATCH v5 00/11] backup-top filter driver for backup Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 01/11] block/backup: simplify backup_incremental_init_copy_bitmap Vladimir Sementsov-Ogievskiy
2019-01-14 13:10 ` Max Reitz
2019-01-14 13:13 ` Max Reitz
2019-01-14 14:01 ` Vladimir Sementsov-Ogievskiy
2019-01-14 14:13 ` Max Reitz
2019-01-14 14:48 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:05 ` Max Reitz
2019-01-23 8:20 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:19 ` Max Reitz
2019-01-23 14:36 ` Eric Blake
2019-01-24 14:20 ` Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 02/11] block/backup: move to copy_bitmap with granularity Vladimir Sementsov-Ogievskiy
2019-01-14 14:10 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 03/11] block: improve should_update_child Vladimir Sementsov-Ogievskiy
2019-01-14 14:32 ` Max Reitz
2019-01-14 16:13 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:17 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 04/11] iotests: handle -f argument correctly for qemu_io_silent Vladimir Sementsov-Ogievskiy
2019-01-14 14:36 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 05/11] iotests: allow resume_drive by node name Vladimir Sementsov-Ogievskiy
2019-01-14 14:46 ` Max Reitz
2019-01-14 16:06 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:11 ` Max Reitz
2019-01-23 13:22 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:31 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:33 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 06/11] iotests: prepare 055 to graph changes during backup job Vladimir Sementsov-Ogievskiy
2019-01-16 13:48 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 07/11] block: introduce backup-top filter driver Vladimir Sementsov-Ogievskiy
2019-01-16 16:02 ` Max Reitz
2019-01-17 12:13 ` Vladimir Sementsov-Ogievskiy
2019-01-18 12:05 ` Max Reitz
2019-01-23 13:47 ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:08 ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:08 ` Vladimir Sementsov-Ogievskiy
2019-04-13 17:03 ` Vladimir Sementsov-Ogievskiy
2019-04-13 17:03 ` Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 08/11] block/io: refactor wait_serialising_requests Vladimir Sementsov-Ogievskiy
2019-01-16 16:18 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 09/11] block: add lock/unlock range functions Vladimir Sementsov-Ogievskiy
2019-01-16 16:36 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 10/11] block/backup: tiny refactor backup_job_create Vladimir Sementsov-Ogievskiy
2019-01-18 13:00 ` Max Reitz [this message]
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers Vladimir Sementsov-Ogievskiy
2019-01-18 14:56 ` Max Reitz
2019-01-28 11:29 ` Vladimir Sementsov-Ogievskiy
2019-01-28 15:59 ` Max Reitz
2019-01-28 16:44 ` Vladimir Sementsov-Ogievskiy
2019-01-28 16:53 ` Max Reitz
2019-01-28 17:14 ` Vladimir Sementsov-Ogievskiy
2019-01-28 17:40 ` Kevin Wolf
2019-01-28 19:00 ` Vladimir Sementsov-Ogievskiy
2019-01-23 15:26 ` [Qemu-devel] [PATCH v5 00/11] backup-top filter driver for backup no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927a196d-fd7d-09bd-65f9-e5ef21c40629@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).