From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH 2/2] hw/block/block.c: improve confusing blk_check_size_and_read_all() error
Date: Tue, 23 Jan 2024 09:12:02 +0100 [thread overview]
Message-ID: <927c417b-d3b6-433c-b63d-335e85df9666@linaro.org> (raw)
In-Reply-To: <e3701762eddf0a58b32ebac7d4c8330e792a2401.1705938003.git.manos.pitsidianakis@linaro.org>
On 23/1/24 09:09, Manos Pitsidianakis wrote:
> In cases where a device tries to read more bytes than the block device
> contains, the error is vague: "device requires X bytes, block backend
> provides Y bytes".
>
> This patch changes the errors of this function to include the block
> backend name, the device id and device type name where appropriate.
>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
> hw/block/block.c | 25 +++++++++++++++----------
> hw/block/m25p80.c | 3 ++-
> hw/block/pflash_cfi01.c | 4 ++--
> hw/block/pflash_cfi02.c | 2 +-
> include/hw/block/block.h | 4 ++--
> 5 files changed, 22 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2024-01-23 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 8:09 [PATCH 0/2] hw/block/block.c: improve confusing error Manos Pitsidianakis
2024-01-23 8:09 ` [PATCH 1/2] hw/core/qdev.c: add qdev_get_human_name() Manos Pitsidianakis
2024-01-23 8:13 ` Philippe Mathieu-Daudé
2024-01-23 8:15 ` Manos Pitsidianakis
2024-01-23 8:23 ` Philippe Mathieu-Daudé
2024-01-23 8:09 ` [PATCH 2/2] hw/block/block.c: improve confusing blk_check_size_and_read_all() error Manos Pitsidianakis
2024-01-23 8:12 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927c417b-d3b6-433c-b63d-335e85df9666@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).