From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer
Date: Mon, 18 May 2020 14:26:51 -0400 [thread overview]
Message-ID: <928e787e-6242-b39e-0aff-8c06f33c9e8d@redhat.com> (raw)
In-Reply-To: <20200515084817.GA93011@linux.fritz.box>
On 5/15/20 4:48 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 22:21 hat John Snow geschrieben:
>>
>>
>> On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote:
>>> Handlers don't need to modify the IDEDMA structure.
>>> Make it const.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>> I'll trust your judgment. As long as it still compiles and passes
>> qtests, I'm happy if you're happy.
>>
>> Acked-by: John Snow <jsnow@redhat.com>
>
> Does this mean you assume someone else will merge it? If that someone is
> me, please let me know.
>
> Kevin
>
I think I had thought this was part of a larger set, and didn't realize
it wasn't.
Yes, if you could please stage this for inclusion, that would be helpful.
next prev parent reply other threads:[~2020-05-18 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 19:49 [PATCH] hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer Philippe Mathieu-Daudé
2020-05-14 20:21 ` John Snow
2020-05-15 7:20 ` Philippe Mathieu-Daudé
2020-05-15 8:48 ` Kevin Wolf
2020-05-18 18:26 ` John Snow [this message]
2020-05-19 8:45 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=928e787e-6242-b39e-0aff-8c06f33c9e8d@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).