From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] 9pfs: fix error path in pdu_submit()
Date: Wed, 20 Dec 2017 13:04:09 -0600 [thread overview]
Message-ID: <92bc11be-2300-fc7c-37c4-f6374399585a@redhat.com> (raw)
In-Reply-To: <151335612254.14991.13093029894103210710.stgit@bahia>
On 12/15/2017 10:42 AM, Greg Kurz wrote:
> If we receive an unsupported request id, we first decide to
> return -ENOTSUPP to the client, but since the request id
> causes is_read_only_op() to return false, we change the
> error to be -EROFS if the fsdev is read-only. This doesn't
> make sense since we don't know what the client asked for.
>
> This patch ensures that -EROFS can only be returned if the
> request id is supported.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> hw/9pfs/9p.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2017-12-20 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 16:42 [Qemu-devel] [PATCH] 9pfs: fix error path in pdu_submit() Greg Kurz
2017-12-20 19:04 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92bc11be-2300-fc7c-37c4-f6374399585a@redhat.com \
--to=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).